You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by kf...@apache.org on 2017/02/02 07:59:40 UTC

svn commit: r1781353 - in /tomcat/trunk: java/org/apache/catalina/tribes/group/RpcChannel.java webapps/docs/changelog.xml

Author: kfujino
Date: Thu Feb  2 07:59:40 2017
New Revision: 1781353

URL: http://svn.apache.org/viewvc?rev=1781353&view=rev
Log:
Ensure that NoRpcChannelReply messages are not received on RpcCallback.

Modified:
    tomcat/trunk/java/org/apache/catalina/tribes/group/RpcChannel.java
    tomcat/trunk/webapps/docs/changelog.xml

Modified: tomcat/trunk/java/org/apache/catalina/tribes/group/RpcChannel.java
URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/tribes/group/RpcChannel.java?rev=1781353&r1=1781352&r2=1781353&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/catalina/tribes/group/RpcChannel.java (original)
+++ tomcat/trunk/java/org/apache/catalina/tribes/group/RpcChannel.java Thu Feb  2 07:59:40 2017
@@ -112,7 +112,8 @@ public class RpcChannel implements Chann
         if ( rmsg.reply ) {
             RpcCollector collector = responseMap.get(key);
             if (collector == null) {
-                callback.leftOver(rmsg.message, sender);
+                if (!(rmsg instanceof RpcMessage.NoRpcChannelReply))
+                    callback.leftOver(rmsg.message, sender);
             } else {
                 synchronized (collector) {
                     //make sure it hasn't been removed

Modified: tomcat/trunk/webapps/docs/changelog.xml
URL: http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1781353&r1=1781352&r2=1781353&view=diff
==============================================================================
--- tomcat/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/trunk/webapps/docs/changelog.xml Thu Feb  2 07:59:40 2017
@@ -146,6 +146,10 @@
         When a PING message that beyond the time-out period has been received,
         make sure that valid member is added to the map membership. (kfujino)
       </fix>
+      <fix>
+        Ensure that <code>NoRpcChannelReply</code> messages are not received on
+        <code>RpcCallback</code>. (kfujino)
+      </fix>
     </changelog>
   </subsection>
   <subsection name="Other">



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org