Re: Review Request 60524: Stout: Made the `Duration` operators handle int overflows explicitly.

[Mesos Reviewbot Windows <re...@mesos.apache.org>]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60524/#review182897
-----------------------------------------------------------



Bad patch!

Reviews applied: [60524, 61621, 60525, 60815, 61601, 60721]

Failed command: python support/apply-reviews.py -n -r 60721

Error:
Traceback (most recent call last):
  File "support/apply-reviews.py", line 417, in <module>
    main()
  File "support/apply-reviews.py", line 412, in main
    reviewboard(options)
  File "support/apply-reviews.py", line 402, in reviewboard
    apply_review(options)
  File "support/apply-reviews.py", line 160, in apply_review
    commit_patch(options)
  File "support/apply-reviews.py", line 268, in commit_patch
    shell(cmd, options['dry_run'])
  File "support/apply-reviews.py", line 144, in shell
    error_code = subprocess.call(command, stderr=subprocess.STDOUT, shell=True)
  File "C:\Python27\lib\subprocess.py", line 168, in call
    return Popen(*popenargs, **kwargs).wait()
  File "C:\Python27\lib\subprocess.py", line 390, in __init__
    errread, errwrite)
  File "C:\Python27\lib\subprocess.py", line 610, in _execute_child
    args = '{} /c "{}"'.format (comspec, args)
UnicodeEncodeError: 'ascii' codec can't encode character u'\xf3' in position 25: ordinal not in range(128)

Full log: http://mesos-winbot.westus.cloudapp.azure.com/logs/221/console

- Mesos Reviewbot Windows


On July 26, 2017, 11:31 p.m., Gastón Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60524/
> -----------------------------------------------------------
> 
> (Updated July 26, 2017, 11:31 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Benjamin Mahler, Greg Mann, and Vinod Kone.
> 
> 
> Bugs: MESOS-7661
>     https://issues.apache.org/jira/browse/MESOS-7661
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Made the `Duration` arithmetic operators return `Duration::max()` if the
> operation would result in an integer overflow, and `Duration::min()` if
> it would result in an underflow.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/duration.hpp b0cd77b833f6fbf752b4db820fd43b87e1d1e476 
>   3rdparty/stout/tests/duration_tests.cpp 59b08f14849a8db31f11fbd0b2e1248c99afd9dd 
> 
> 
> Diff: https://reviews.apache.org/r/60524/diff/5/
> 
> 
> Testing
> -------
> 
> Added new Stout tests and confirmed that the Mesos test suite still passes.
> 
> 
> Thanks,
> 
> Gastón Kleiman
> 
>