[GitHub] [openwhisk] bdoyle0182 commented on a change in pull request #5125: [New Scheduler] Implement FPCInvokerReactive

[GitBox <gi...@apache.org>]

bdoyle0182 commented on a change in pull request #5125:
URL: https://github.com/apache/openwhisk/pull/5125#discussion_r652142899



##########
File path: common/scala/src/main/scala/org/apache/openwhisk/core/entity/Identity.scala
##########
@@ -35,12 +35,14 @@ case class UserLimits(invocationsPerMinute: Option[Int] = None,
                       concurrentInvocations: Option[Int] = None,
                       firesPerMinute: Option[Int] = None,
                       allowedKinds: Option[Set[String]] = None,
-                      storeActivations: Option[Boolean] = None)
+                      storeActivations: Option[Boolean] = None,
+                      warmedContainerKeepingCount: Option[Int] = None,
+                      warmedContainerKeepingTimeout: Option[String] = None)

Review comment:
       I'm not opposed to infecting non-scheduler code where absolutely necessary. I think it's unreasonable to suggest we can make such a large architectural change without touching existing code at all. So long as we're avoiding a breaking change I see no issue with this




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org