[GitHub] spark pull request #21561: [SPARK-24555][ML] logNumExamples in KMeans/BiKM/G...

[srowen <gi...@git.apache.org>]

Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21561#discussion_r209256325
  
    --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/BisectingKMeans.scala ---
    @@ -151,13 +152,9 @@ class BisectingKMeans private (
         this
       }
     
    -  /**
    -   * Runs the bisecting k-means algorithm.
    -   * @param input RDD of vectors
    -   * @return model for the bisecting kmeans
    -   */
    -  @Since("1.6.0")
    -  def run(input: RDD[Vector]): BisectingKMeansModel = {
    +
    +  private[spark] def run(input: RDD[Vector],
    +                         instr: Option[Instrumentation]): BisectingKMeansModel = {
    --- End diff --
    
    Elsewhere I see the instrumentation made available with "insrumented" -- is this different?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org