You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by "J-Bakuli (via GitHub)" <gi...@apache.org> on 2023/04/19 08:30:16 UTC

[GitHub] [ignite] J-Bakuli commented on a diff in pull request #10638: IGNITE-19164 Improve message about requested partitions during snapshot restore

J-Bakuli commented on code in PR #10638:
URL: https://github.com/apache/ignite/pull/10638#discussion_r1171000992


##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/SnapshotRestoreProcess.java:
##########
@@ -1114,11 +1114,14 @@ private IgniteInternalFuture<Boolean> preload(UUID reqId) {
 
             try {
                 if (log.isInfoEnabled() && !snpAff.isEmpty()) {
-                    log.info("Trying to request partitions from remote nodes " +
-                        "[reqId=" + reqId +
-                        ", snapshot=" + opCtx0.snpName +
-                        ", map=" + snpAff.entrySet().stream().collect(Collectors.toMap(Map.Entry::getKey,
-                            e -> partitionsMapToString(e.getValue()))) + ']');
+                    for (Map.Entry<UUID, Map<Integer, Set<Integer>>> m : snpAff.entrySet()) {
+                        log.info("Trying to request partitions from remote nodes " +
+                            "[reqId=" + reqId +
+                            ", snapshot=" + opCtx0.snpName +
+                            ", consistentId=" + locNode.consistentId() +

Review Comment:
   thank you, I have changed the output by updating consistentId. Adding cacheName, groupName is tricky as we discussed it with you last week. Is it strongly necessary?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org