You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Michael Koch (JIRA)" <ji...@codehaus.org> on 2008/06/11 14:16:12 UTC

[jira] Commented: (SCM-334) Faulty svn commandline is generated for passwords containing special chars

    [ http://jira.codehaus.org/browse/SCM-334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=138160#action_138160 ] 

Michael Koch commented on SCM-334:
----------------------------------

Single quoting the whole password is easier that checking for special chars and quoting them individually.  Nevertheless, as you probably assumed, any single quotes in the password will still need to be quoted.

I guess that this problem also applies to the user name. Perhaps all arguments should be quoted to be on the safe side.

> Faulty svn commandline is generated for passwords containing special chars
> --------------------------------------------------------------------------
>
>                 Key: SCM-334
>                 URL: http://jira.codehaus.org/browse/SCM-334
>             Project: Maven SCM
>          Issue Type: Bug
>          Components: maven-scm-provider-svn
>    Affects Versions: 1.0
>         Environment: All
>            Reporter: Jan Lisse
>            Priority: Critical
>         Attachments: patch.txt
>
>
> If i use a svn password containing a semicolon with the maven-scm-provider-svnexe, the commandline generated by SvnCommandlineUtils is faulty, because
> the password is not quoted. Passwords containing other special chars might cause problems too. 
> Solution: Enclosing the password for the commandline in single quotes solves this problem. 
> I have attached a patch for SvnCommandlineUtils that fixes this issue.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira