You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Aditya Kishore (JIRA)" <ji...@apache.org> on 2012/10/12 21:11:02 UTC

[jira] [Created] (HBASE-6989) Avoid unneceseary regular expression matching in ruby code for "list" command

Aditya Kishore created HBASE-6989:
-------------------------------------

             Summary: Avoid unneceseary regular expression matching in ruby code for "list" command
                 Key: HBASE-6989
                 URL: https://issues.apache.org/jira/browse/HBASE-6989
             Project: HBase
          Issue Type: Bug
          Components: shell
            Reporter: Aditya Kishore
            Assignee: Aditya Kishore
            Priority: Minor


HBaseAdmin already has an API which can accept a regular expression string and return the matching tables.

The list command in HBase shell should make use of this and should not pull the entire table list and do a matching of its own

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HBASE-6989) Avoid unneceseary regular expression matching in ruby code for "list" command

Posted by "Aditya Kishore (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-6989?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Aditya Kishore updated HBASE-6989:
----------------------------------

    Status: Open  (was: Patch Available)

Cancelling and resubmitting the patch.
                
> Avoid unneceseary regular expression matching in ruby code for "list" command
> -----------------------------------------------------------------------------
>
>                 Key: HBASE-6989
>                 URL: https://issues.apache.org/jira/browse/HBASE-6989
>             Project: HBase
>          Issue Type: Bug
>          Components: shell
>    Affects Versions: 0.96.0
>            Reporter: Aditya Kishore
>            Assignee: Aditya Kishore
>            Priority: Minor
>             Fix For: 0.96.0
>
>         Attachments: HBASE-6989.patch
>
>
> HBaseAdmin already has an API which can accept a regular expression string and return the matching tables.
> The list command in HBase shell should make use of this and should not pull the entire table list and do a matching of its own

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-6989) Avoid unneceseary regular expression matching in ruby code for "list" command

Posted by "stack (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-6989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13475293#comment-13475293 ] 

stack commented on HBASE-6989:
------------------------------

+1 on patch.  Lets see what hadoopqa says.
                
> Avoid unneceseary regular expression matching in ruby code for "list" command
> -----------------------------------------------------------------------------
>
>                 Key: HBASE-6989
>                 URL: https://issues.apache.org/jira/browse/HBASE-6989
>             Project: HBase
>          Issue Type: Bug
>          Components: shell
>    Affects Versions: 0.96.0
>            Reporter: Aditya Kishore
>            Assignee: Aditya Kishore
>            Priority: Minor
>             Fix For: 0.96.0
>
>         Attachments: HBASE-6989.patch
>
>
> HBaseAdmin already has an API which can accept a regular expression string and return the matching tables.
> The list command in HBase shell should make use of this and should not pull the entire table list and do a matching of its own

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HBASE-6989) Avoid unneceseary regular expression matching in ruby code for "list" command

Posted by "Aditya Kishore (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-6989?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Aditya Kishore updated HBASE-6989:
----------------------------------

        Fix Version/s: 0.96.0
    Affects Version/s: 0.96.0
               Status: Patch Available  (was: Open)

Submitting patch for trunk
                
> Avoid unneceseary regular expression matching in ruby code for "list" command
> -----------------------------------------------------------------------------
>
>                 Key: HBASE-6989
>                 URL: https://issues.apache.org/jira/browse/HBASE-6989
>             Project: HBase
>          Issue Type: Bug
>          Components: shell
>    Affects Versions: 0.96.0
>            Reporter: Aditya Kishore
>            Assignee: Aditya Kishore
>            Priority: Minor
>             Fix For: 0.96.0
>
>         Attachments: HBASE-6989.patch
>
>
> HBaseAdmin already has an API which can accept a regular expression string and return the matching tables.
> The list command in HBase shell should make use of this and should not pull the entire table list and do a matching of its own

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-6989) Avoid unneceseary regular expression matching in ruby code for "list" command

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-6989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13475313#comment-13475313 ] 

Hadoop QA commented on HBASE-6989:
----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12548938/HBASE-6989.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 hadoop2.0{color}.  The patch compiles against the hadoop 2.0 profile.

    {color:red}-1 javadoc{color}.  The javadoc tool appears to have generated 81 warning messages.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:red}-1 findbugs{color}.  The patch appears to introduce 5 new Findbugs (version 1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
                       org.apache.hadoop.hbase.backup.example.TestZooKeeperTableArchiveClient

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/3043//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3043//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3043//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3043//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3043//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3043//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3043//console

This message is automatically generated.
                
> Avoid unneceseary regular expression matching in ruby code for "list" command
> -----------------------------------------------------------------------------
>
>                 Key: HBASE-6989
>                 URL: https://issues.apache.org/jira/browse/HBASE-6989
>             Project: HBase
>          Issue Type: Bug
>          Components: shell
>    Affects Versions: 0.96.0
>            Reporter: Aditya Kishore
>            Assignee: Aditya Kishore
>            Priority: Minor
>             Fix For: 0.96.0
>
>         Attachments: HBASE-6989.patch
>
>
> HBaseAdmin already has an API which can accept a regular expression string and return the matching tables.
> The list command in HBase shell should make use of this and should not pull the entire table list and do a matching of its own

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HBASE-6989) Avoid unneceseary regular expression matching in ruby code for "list" command

Posted by "Aditya Kishore (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-6989?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Aditya Kishore updated HBASE-6989:
----------------------------------

    Status: Patch Available  (was: Open)
    
> Avoid unneceseary regular expression matching in ruby code for "list" command
> -----------------------------------------------------------------------------
>
>                 Key: HBASE-6989
>                 URL: https://issues.apache.org/jira/browse/HBASE-6989
>             Project: HBase
>          Issue Type: Bug
>          Components: shell
>    Affects Versions: 0.96.0
>            Reporter: Aditya Kishore
>            Assignee: Aditya Kishore
>            Priority: Minor
>             Fix For: 0.96.0
>
>         Attachments: HBASE-6989.patch
>
>
> HBaseAdmin already has an API which can accept a regular expression string and return the matching tables.
> The list command in HBase shell should make use of this and should not pull the entire table list and do a matching of its own

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HBASE-6989) Avoid unneceseary regular expression matching in ruby code for "list" command

Posted by "Aditya Kishore (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-6989?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Aditya Kishore updated HBASE-6989:
----------------------------------

    Attachment: HBASE-6989.patch
    
> Avoid unneceseary regular expression matching in ruby code for "list" command
> -----------------------------------------------------------------------------
>
>                 Key: HBASE-6989
>                 URL: https://issues.apache.org/jira/browse/HBASE-6989
>             Project: HBase
>          Issue Type: Bug
>          Components: shell
>    Affects Versions: 0.96.0
>            Reporter: Aditya Kishore
>            Assignee: Aditya Kishore
>            Priority: Minor
>             Fix For: 0.96.0
>
>         Attachments: HBASE-6989.patch
>
>
> HBaseAdmin already has an API which can accept a regular expression string and return the matching tables.
> The list command in HBase shell should make use of this and should not pull the entire table list and do a matching of its own

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HBASE-6989) Avoid unneceseary regular expression matching in ruby code for "list" command

Posted by "stack (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-6989?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

stack updated HBASE-6989:
-------------------------

      Resolution: Fixed
    Hadoop Flags: Reviewed
          Status: Resolved  (was: Patch Available)

Committed to trunk.  Thanks for the patch Aditya.
                
> Avoid unneceseary regular expression matching in ruby code for "list" command
> -----------------------------------------------------------------------------
>
>                 Key: HBASE-6989
>                 URL: https://issues.apache.org/jira/browse/HBASE-6989
>             Project: HBase
>          Issue Type: Bug
>          Components: shell
>    Affects Versions: 0.96.0
>            Reporter: Aditya Kishore
>            Assignee: Aditya Kishore
>            Priority: Minor
>             Fix For: 0.96.0
>
>         Attachments: HBASE-6989.patch
>
>
> HBaseAdmin already has an API which can accept a regular expression string and return the matching tables.
> The list command in HBase shell should make use of this and should not pull the entire table list and do a matching of its own

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-6989) Avoid unneceseary regular expression matching in ruby code for "list" command

Posted by "Aditya Kishore (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-6989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13475582#comment-13475582 ] 

Aditya Kishore commented on HBASE-6989:
---------------------------------------

The test failure in TestZooKeeperTableArchiveClient.testMultipleTables() is unrelated to the patch.
                
> Avoid unneceseary regular expression matching in ruby code for "list" command
> -----------------------------------------------------------------------------
>
>                 Key: HBASE-6989
>                 URL: https://issues.apache.org/jira/browse/HBASE-6989
>             Project: HBase
>          Issue Type: Bug
>          Components: shell
>    Affects Versions: 0.96.0
>            Reporter: Aditya Kishore
>            Assignee: Aditya Kishore
>            Priority: Minor
>             Fix For: 0.96.0
>
>         Attachments: HBASE-6989.patch
>
>
> HBaseAdmin already has an API which can accept a regular expression string and return the matching tables.
> The list command in HBase shell should make use of this and should not pull the entire table list and do a matching of its own

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira