[GitHub] [echarts] plainheart edited a comment on pull request #13929: feat(symbol): various clipping on the symbol.

[GitBox <gi...@apache.org>]

plainheart edited a comment on pull request #13929:
URL: https://github.com/apache/echarts/pull/13929#issuecomment-754638144


   > I think we don't have to implement the string expression of CSS clip-path. It's too complex and not easy to debug. Also, it's not friendly for type checking. We prefer to express the clipping by object configuration like color gradient, for example:
   > 
   > ```ts
   > clipPath: { type: 'rect', shape: {xxxxx} }
   > ```
   > 
   > I think we have similar configurations in the `graphic` component.
   > 
   
   @pissang No problem. The object configuration rule is my very first implementation scheme.
   But after a short time, I think it may be better to follow the CSS rule because the developers needn't make extra conversions and changes. So I made a refactor for this.
   If making an object for `clip-path` is better, I will revert the implementation and dive into it.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org