You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/12/28 13:55:35 UTC

[GitHub] [iceberg] Fokko commented on a diff in pull request #6501: Python: Use PyArrow buffer

Fokko commented on code in PR #6501:
URL: https://github.com/apache/iceberg/pull/6501#discussion_r1058364492


##########
python/pyiceberg/avro/file.py:
##########
@@ -183,7 +182,6 @@ def __next__(self) -> Record:
         raise StopIteration
 
     def _read_header(self) -> AvroFileHeader:
-        self.input_stream.seek(0, SEEK_SET)

Review Comment:
   Seek is not allowed on a stream, but it is okay to leave this out since we do this directly after opening the file and we call it only once (after that it is cached)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org