[GitHub] [arrow-nanoarrow] lidavidm commented on a diff in pull request #258: Add Support for Intervals

["lidavidm (via GitHub)" <gi...@apache.org>]

lidavidm commented on code in PR #258:
URL: https://github.com/apache/arrow-nanoarrow/pull/258#discussion_r1265797465


##########
src/nanoarrow/nanoarrow_types.h:
##########
@@ -656,6 +672,15 @@ struct ArrowArrayPrivateData {
   int8_t union_type_id_is_child_index;
 };
 
+/// \brief A representation of an interval.
+struct ArrowInterval {
+  /// \brief The type of interval being used
+  enum ArrowIntervalUnit unit;
+
+  /// \brief Pointer containing the underlying data for the interval
+  void* data;

Review Comment:
   Possibly a `union` is preferable here to avoid an extra pointer indirection?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org