[GitHub] [helix] narendly commented on a change in pull request #1429: Add Zookeeper multi ops support in the Helix ZkClient.

[GitBox <gi...@apache.org>]

narendly commented on a change in pull request #1429:
URL: https://github.com/apache/helix/pull/1429#discussion_r498982918



##########
File path: zookeeper-api/src/main/java/org/apache/helix/zookeeper/api/client/RealmAwareZkClient.java
##########
@@ -261,8 +261,11 @@ void asyncSetData(final String path, Object datat, final int version,
 
   long getCreationTime(String path);
 
+  @Deprecated
   List<OpResult> multi(final Iterable<Op> ops);

Review comment:
       Is deprecating this is a necessity here? zookeeper-api is supposed to be a general-purpose client library as well (not just tailored for Helix usage), so I don't see the need for it quite yet. My opinion is that we should continue to maintain the interface defined in the original ZkClient.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org