You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by bu...@apache.org on 2014/11/29 18:30:15 UTC
[Bug 57284] New: When in async mode and calling it from another
thread, chain.doFilter() throws NPE
https://issues.apache.org/bugzilla/show_bug.cgi?id=57284
Bug ID: 57284
Summary: When in async mode and calling it from another thread,
chain.doFilter() throws NPE
Product: Tomcat 7
Version: 7.0.56
Hardware: PC
URL: https://github.com/circlespainter/servlet3-filter-asyn
c-test
Status: NEW
Severity: major
Priority: P2
Component: Catalina
Assignee: dev@tomcat.apache.org
Reporter: ftudone@libero.it
Also happens in 7.0.57 and 8.0.15.
Exception in thread "Thread-1" java.lang.NullPointerException
at
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:258)
at
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:208)
at servlet.thread.ThreadFilter$1.run(ThreadFilter.java:60)
at java.lang.Thread.run(Thread.java:745)
Complete (Gradle-based) test here:
https://github.com/circlespainter/servlet3-filter-async-test
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 57284] When in async mode and calling it from another thread,
chain.doFilter() throws NPE
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=57284
--- Comment #6 from Eugene Chung (TmaxSoft) <bl...@gmail.com> ---
FYI : I hope it might help you that AsyncContext.dispatch() mechanism supports
FilterChain.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 57284] When in async mode and calling it from another thread,
chain.doFilter() throws NPE
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=57284
Mark Thomas <ma...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
OS| |All
--- Comment #1 from Mark Thomas <ma...@apache.org> ---
My favourite kind of bug fix. One where all I have to do is delete stuff. This
will be committed to trunk and back-ported to 8.0.x and 7.0.x when svn returns
to read-write:
https://github.com/markt-asf/tomcat/commit/fe5fd7ba6b44dbc7ffad65dc6e906278109e58eb
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 57284] When in async mode and calling it from another thread,
chain.doFilter() throws NPE
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=57284
--- Comment #9 from ftudone@libero.it ---
I understand your point that there would be several implications. Still the API
shape itself doesn't forbid attempting to do such things, so I think it would
be better, if reasonably feasible, that such conditions were reported to the
developer with at least some indication about them not being allowed.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 57284] When in async mode and calling it from another thread,
chain.doFilter() throws NPE
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=57284
Mark Thomas <ma...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|REOPENED |RESOLVED
Resolution|--- |INVALID
--- Comment #4 from Mark Thomas <ma...@apache.org> ---
The fix has been reverted. Given the text in section 6.2.3, I am resolving this
as invalid until such time the Servlet EG clarifies that 6.2.3 does not apply
to asycn requests.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 57284] When in async mode and calling it from another thread,
chain.doFilter() throws NPE
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=57284
--- Comment #7 from ftudone@libero.it ---
Thanks, yes it dispatches to a whole new processing chain including filters but
it will do so in the context of another servlet container thread, so it's not
very useful for this specific case of avoiding using threads.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 57284] When in async mode and calling it from another thread,
chain.doFilter() throws NPE
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=57284
Mark Thomas <ma...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |FIXED
--- Comment #2 from Mark Thomas <ma...@apache.org> ---
This has been fixed in trunk and in 8.0.x (for 8.0.16 onwards).
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 57284] When in async mode and calling it from another thread,
chain.doFilter() throws NPE
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=57284
--- Comment #10 from Remy Maucherat <re...@apache.org> ---
There is nothing to "understand", this has always been 100% clear for everyone
and all implementations, and the specification will be clarified. I have no
idea how a reasonable developer could actually infer that this behavior was
actually allowed.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 57284] When in async mode and calling it from another thread,
chain.doFilter() throws NPE
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=57284
--- Comment #11 from Fabio Tudone <ft...@libero.it> ---
Ok, thanks for discussing this anyway.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 57284] When in async mode and calling it from another thread,
chain.doFilter() throws NPE
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=57284
--- Comment #8 from Remy Maucherat <re...@apache.org> ---
Since the discussion is going on in the Servlet EG, and this is used as a
reference, I have to mention this makes no sense to me.
- Detaching a filter chain prevents any reuse, its state has to be frozen and
thus every invocation would need a new instance
- This breaks EE (naming, etc, should be available when invoking the Servlet,
here obviously it is not going to happen)
- Async invocations likes this should, well, use async instead (the Servlet API
async is under the control of the container, and it can provide its EE
environment)
I think it would be better if Tomcat kept deviations from specifications and
established behaviors down to a minimum.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 57284] When in async mode and calling it from another thread,
chain.doFilter() throws NPE
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=57284
Konstantin Kolinko <kn...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |REOPENED
Resolution|FIXED |---
--- Comment #3 from Konstantin Kolinko <kn...@gmail.com> ---
The stacktrace: you are trying to call FilterChain.doFilter() from within a
runnable ($1)?
It is wrong and contradicts with chapter 6 (Filters) of the Servlet
Specification.
<quote>A Filter and the target servlet or resource at the end
of the filter chain must execute in the same invocation thread.</quote>
FilterChain.doFilter() cannot be called from a different thread.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 57284] When in async mode and calling it from another thread,
chain.doFilter() throws NPE
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=57284
--- Comment #5 from ftudone@libero.it ---
Yes, indeed Im trying to call from a different thread.
My apologies for not having checked the spec and for having instead just
assumed it should work; my reasoning is that it can be very useful to start
async mode in filters (so, early in the request processing chain) rather than
in the servlet.
For example I'm working on several web framework integrations with Quasar
(https://github.com/puniverse/quasar), a technology that enables dispatching
execution to "fibers" (which can be much cheaper than threads). Being able to
dispatch potentially expensive filter processing to fiber-based execution
contexts would be a good thing (plus it would make async processing more
transparent for the framework being integrated).
I think supporting more than the servlet spec mandates is not a bad thing per
se, but in case in this circumstance this is not sensible in your opinion,
would it be possible at least to throw some exception pointing at the wrong
usage?
TIA
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org