You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2019/07/13 00:07:22 UTC
[GitHub] [incubator-pinot] buchireddy edited a comment on issue #4432: #4401
Reuse a ThreadLocal byte[] when reading String elements from the variable
length value reader.
buchireddy edited a comment on issue #4432: #4401 Reuse a ThreadLocal byte[] when reading String elements from the variable length value reader.
URL: https://github.com/apache/incubator-pinot/pull/4432#issuecomment-511068275
> Can you please post some perf number of this improvement?
I've done some quick tests with the same `StringDictionaryPerfTest` that I've used to compare the variable length dictionary with fixed length dictionary earlier and compared the cost of `getValues()` both with and without my changes. I see some improvement in the latency for cardinality <1M. Please note that the red line and blue line are with my changes and they both lie below the yellow and green ones for cardinality <1M. I'm wondering why it's going above the other lines for >1M cardinality though. Thinking further on that.
cc @Jackie-Jiang
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org