You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by afine <gi...@git.apache.org> on 2017/02/24 23:15:05 UTC
[GitHub] zookeeper pull request #181: ZOOKEEPER-2706: checkstyle broken on branch-3.4
GitHub user afine opened a pull request:
https://github.com/apache/zookeeper/pull/181
ZOOKEEPER-2706: checkstyle broken on branch-3.4
This is essentially a backport of ZOOKEEPER-412.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/afine/zookeeper ZOOKEEPER-2706
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zookeeper/pull/181.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #181
----
commit 12966a6b8303b9eb6ef67f95ad7f564dcc8e4d09
Author: Abraham Fine <af...@apache.org>
Date: 2017-02-24T23:11:14Z
ZOOKEEPER-2706: checkstyle broken on branch-3.4
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zookeeper issue #181: ZOOKEEPER-2706: checkstyle broken on branch-3.4
Posted by hanm <gi...@git.apache.org>.
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/181
Patch look good. Defer to @rakeshadr for another look and commit (since we are in the middle of 3.4 release.).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zookeeper pull request #181: ZOOKEEPER-2706: checkstyle broken on branch-3.4
Posted by rakeshadr <gi...@git.apache.org>.
Github user rakeshadr commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/181#discussion_r107370339
--- Diff: ivy.xml ---
@@ -58,7 +58,7 @@
<dependency org="junit" name="junit" rev="4.8.1" conf="test->default"/>
<dependency org="org.mockito" name="mockito-all" rev="1.8.2"
conf="test->default"/>
- <dependency org="checkstyle" name="checkstyle" rev="5.0"
+ <dependency org="com.puppycrawl.tools" name="checkstyle" rev="6.13"
--- End diff --
Thank you @afine for the patch. I could see checkstyle version "6.13" resulting errors when running with Java 1.6, should we consider java1.6?
`https://zookeeper.apache.org/doc/r3.4.9/zookeeperAdmin.html#sc_supportedPlatforms`
```
/home/max/Projects/zk/git/b-3.4/build.xml:1592: java.lang.UnsupportedClassVersionError: com/puppycrawl/tools/checkstyle/ant/CheckstyleAntTask : Unsupported major.minor version 51.0
at java.lang.ClassLoader.defineClass1(Native Method)
at java.lang.ClassLoader.defineClassCond(ClassLoader.java:637)
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zookeeper issue #181: ZOOKEEPER-2706: checkstyle broken on branch-3.4
Posted by afine <gi...@git.apache.org>.
Github user afine commented on the issue:
https://github.com/apache/zookeeper/pull/181
@rakeshadr any possibility that you can take a look at this one?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zookeeper issue #181: ZOOKEEPER-2706: checkstyle broken on branch-3.4
Posted by rakeshadr <gi...@git.apache.org>.
Github user rakeshadr commented on the issue:
https://github.com/apache/zookeeper/pull/181
Thank you @afine for the quick reply. +1 lgtm. I will merge this shortly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zookeeper pull request #181: ZOOKEEPER-2706: checkstyle broken on branch-3.4
Posted by afine <gi...@git.apache.org>.
Github user afine closed the pull request at:
https://github.com/apache/zookeeper/pull/181
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zookeeper issue #181: ZOOKEEPER-2706: checkstyle broken on branch-3.4
Posted by afine <gi...@git.apache.org>.
Github user afine commented on the issue:
https://github.com/apache/zookeeper/pull/181
This should be working on java 6 and 7 now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---