You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/11/01 08:58:40 UTC

[GitHub] [inlong] healchow commented on a diff in pull request #6354: [INLONG-6352][Manager] Set whether to push the sort configuration through zk using the global configuration

healchow commented on code in PR #6354:
URL: https://github.com/apache/inlong/pull/6354#discussion_r1010222513


##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/group/InlongGroupServiceImpl.java:
##########
@@ -246,6 +250,7 @@ public String update(InlongGroupRequest request, String operator) {
         // check whether the current status can be modified
         checkGroupCanUpdate(entity, request, operator);
 
+        request.setEnableZookeeper(enableZookeeper ? 1 : 0);

Review Comment:
   Suggest using `InlongConstants.DISABLE_ZK` instead a magic number.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org