You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by bowenli86 <gi...@git.apache.org> on 2017/07/20 06:43:27 UTC

[GitHub] flink pull request #4375: [Flink 6365][kinesis-connector] Adapt default valu...

GitHub user bowenli86 opened a pull request:

    https://github.com/apache/flink/pull/4375

    [Flink 6365][kinesis-connector] Adapt default values of the Kinesis connector

    Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
    If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
    In addition to going through the list, please provide a meaningful description of your changes.
    
    - [x] General
      - The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
      - The pull request addresses only one issue
      - Each commit in the PR has a meaningful commit message (including the JIRA id)
    
    - [x] Documentation
      - Documentation has been added for new functionality
      - Old documentation affected by the pull request has been updated
      - JavaDoc for public methods has been added
    
    - [x] Tests & Build
      - Functionality added by the pull request is covered by tests
      - `mvn clean verify` has been executed successfully locally or a Travis build has passed


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/bowenli86/flink FLINK-6365

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4375.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4375
    
----
commit 858f32828845e244843a33fdafd6b379d61eff86
Author: Bowen Li <bo...@gmail.com>
Date:   2017-07-20T06:35:28Z

    FLINK-6365 Adapt default values of the Kinesis connector

commit e8526acd49a0c9f36776b6069c8204399bceb1c5
Author: Bowen Li <bo...@gmail.com>
Date:   2017-07-20T06:41:26Z

    update doc

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request #4375: [Flink-6365][kinesis-connector] Adapt default valu...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/4375


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #4375: [Flink-6365][kinesis-connector] Adapt default values of t...

Posted by tzulitai <gi...@git.apache.org>.
Github user tzulitai commented on the issue:

    https://github.com/apache/flink/pull/4375
  
    Thanks for the PR!
    Since this was already thoroughly discussed, this LGTM.
    Merging ..


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---