You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/12/17 02:11:41 UTC

[GitHub] [tvm] wrongtest commented on pull request #9755: [TIRScript] fix parse StringImm value in for loop annotations

wrongtest commented on pull request #9755:
URL: https://github.com/apache/tvm/pull/9755#issuecomment-996377713


   @vinx13  Hi, the issue is about string dict value as a clarification. The parser already convert str to StringImm in annotations but provide the old dict (maybe a typo).
   
   For the pass, currently it assumes all dict values should be of `PrimExpr` in annotations. Did you mean we can allow some "compatible" values to convert to `PrimExpr` instead of simple downcasts?
   https://github.com/apache/tvm/blob/main/src/tir/transforms/flatten_buffer.cc#L99-L106


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org