You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@geode.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2020/11/30 17:38:00 UTC
[jira] [Commented] (GEODE-8745) Closing the region backing the
queue when the serial gateway sender is stopped.
[ https://issues.apache.org/jira/browse/GEODE-8745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17240912#comment-17240912 ]
ASF GitHub Bot commented on GEODE-8745:
---------------------------------------
nabarunnag commented on a change in pull request #5770:
URL: https://github.com/apache/geode/pull/5770#discussion_r532776796
##########
File path: geode-core/src/main/java/org/apache/geode/internal/cache/wan/serial/SerialGatewaySenderEventProcessor.java
##########
@@ -111,10 +111,9 @@ public SerialGatewaySenderEventProcessor(AbstractGatewaySender sender, String id
ThreadsMonitoring tMonitoring, boolean cleanQueues) {
super("Event Processor for GatewaySender_" + id, sender, tMonitoring);
+ initializeMessageQueue(id, cleanQueues);
Review comment:
This change is because the CacheListener to handle the unprocessedEventsMap is set here, hence I wanted the listener to be up and running before the map is initialized so the no events are missed because they were put in the map before the listener was running.
##########
File path: geode-core/src/main/java/org/apache/geode/internal/cache/wan/serial/SerialGatewaySenderEventProcessor.java
##########
@@ -111,10 +111,9 @@ public SerialGatewaySenderEventProcessor(AbstractGatewaySender sender, String id
ThreadsMonitoring tMonitoring, boolean cleanQueues) {
super("Event Processor for GatewaySender_" + id, sender, tMonitoring);
+ initializeMessageQueue(id, cleanQueues);
Review comment:
This change is because the CacheListener to handle the unprocessedEventsMap is set here, hence I wanted the listener to be up and running before the map is initialized so that no events are missed because they were put in the map before the listener was running.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
> Closing the region backing the queue when the serial gateway sender is stopped.
> -------------------------------------------------------------------------------
>
> Key: GEODE-8745
> URL: https://issues.apache.org/jira/browse/GEODE-8745
> Project: Geode
> Issue Type: Task
> Components: wan
> Reporter: Nabarun Nag
> Priority: Major
>
> In the commit for GEODE-7458, when the sender is stopped, the region backing the queues are no more closed, but just remove the cache listeners.
> This is causing a problem, as the regions continue to exist, it keeps on storing entry events and hence the queue size never gets to zero.
> Also, as the region exists but before attaching the cache listener when restarting the sender leads to entries being never removed from the unprocessed event map.
>
> As mention in the PR for GEODE-7458 - "This option is only applicable for Gateway Senders with enabled persistence."
> Hence believe that it is ok to close the region as the disk files will still be maintained. so when we restart the values can be obtained back from the disk stores.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)