You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Konstantin Shvachko (JIRA)" <ji...@apache.org> on 2008/11/07 09:28:47 UTC

[jira] Created: (HADOOP-4613) browseBlock.jsp does not generate "genstamp" property.

browseBlock.jsp does not generate "genstamp" property.
------------------------------------------------------

                 Key: HADOOP-4613
                 URL: https://issues.apache.org/jira/browse/HADOOP-4613
             Project: Hadoop Core
          Issue Type: Bug
    Affects Versions: 0.18.0
            Reporter: Konstantin Shvachko
             Fix For: 0.18.3


A link to a block replica display page on the web UI breaks with the following message: "Invalid input (genstamp absent)".
The reason is that browsBlock.jsp sets "genstamp=" in the code two times out of three. 
One spot in line #148 was missed by HADOOP-2656.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-4613) browseBlock.jsp does not generate "genstamp" property.

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-4613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12655113#action_12655113 ] 

Hadoop QA commented on HADOOP-4613:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12394658/HADOOP-4613.patch
  against trunk revision 724931.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no tests are needed for this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 Eclipse classpath. The patch retains Eclipse classpath integrity.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3698/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3698/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3698/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3698/console

This message is automatically generated.

> browseBlock.jsp does not generate "genstamp" property.
> ------------------------------------------------------
>
>                 Key: HADOOP-4613
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4613
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.18.0
>            Reporter: Konstantin Shvachko
>            Assignee: Johan Oskarsson
>             Fix For: 0.18.3
>
>         Attachments: HADOOP-4613.patch
>
>
> A link to a block replica display page on the web UI breaks with the following message: "Invalid input (genstamp absent)".
> The reason is that browsBlock.jsp sets "genstamp=" in the code two times out of three. 
> One spot in line #148 was missed by HADOOP-2656.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-4613) browseBlock.jsp does not generate "genstamp" property.

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-4613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12655653#action_12655653 ] 

Hudson commented on HADOOP-4613:
--------------------------------

Integrated in Hadoop-trunk #685 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/685/])
    . Fix block browsing on Web UI. Contributed by Johan Oskarsson.


> browseBlock.jsp does not generate "genstamp" property.
> ------------------------------------------------------
>
>                 Key: HADOOP-4613
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4613
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.18.0
>            Reporter: Konstantin Shvachko
>            Assignee: Johan Oskarsson
>             Fix For: 0.18.3
>
>         Attachments: HADOOP-4613.patch
>
>
> A link to a block replica display page on the web UI breaks with the following message: "Invalid input (genstamp absent)".
> The reason is that browsBlock.jsp sets "genstamp=" in the code two times out of three. 
> One spot in line #148 was missed by HADOOP-2656.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-4613) browseBlock.jsp does not generate "genstamp" property.

Posted by "Johan Oskarsson (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-4613?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Johan Oskarsson updated HADOOP-4613:
------------------------------------

    Attachment: HADOOP-4613.patch

Is this what you had in mind Konstantin? One line, adds:
"&genstamp=" + cur.getBlock().getGenerationStamp() +

> browseBlock.jsp does not generate "genstamp" property.
> ------------------------------------------------------
>
>                 Key: HADOOP-4613
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4613
>             Project: Hadoop Core
>          Issue Type: Bug
>    Affects Versions: 0.18.0
>            Reporter: Konstantin Shvachko
>             Fix For: 0.18.3
>
>         Attachments: HADOOP-4613.patch
>
>
> A link to a block replica display page on the web UI breaks with the following message: "Invalid input (genstamp absent)".
> The reason is that browsBlock.jsp sets "genstamp=" in the code two times out of three. 
> One spot in line #148 was missed by HADOOP-2656.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-4613) browseBlock.jsp does not generate "genstamp" property.

Posted by "Konstantin Shvachko (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-4613?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Konstantin Shvachko updated HADOOP-4613:
----------------------------------------

    Resolution: Fixed
        Status: Resolved  (was: Patch Available)

I just committed this. Thank you Johan.

> browseBlock.jsp does not generate "genstamp" property.
> ------------------------------------------------------
>
>                 Key: HADOOP-4613
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4613
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.18.0
>            Reporter: Konstantin Shvachko
>            Assignee: Johan Oskarsson
>             Fix For: 0.18.3
>
>         Attachments: HADOOP-4613.patch
>
>
> A link to a block replica display page on the web UI breaks with the following message: "Invalid input (genstamp absent)".
> The reason is that browsBlock.jsp sets "genstamp=" in the code two times out of three. 
> One spot in line #148 was missed by HADOOP-2656.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-4613) browseBlock.jsp does not generate "genstamp" property.

Posted by "Konstantin Shvachko (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-4613?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Konstantin Shvachko updated HADOOP-4613:
----------------------------------------

    Hadoop Flags: [Reviewed]
          Status: Patch Available  (was: Open)

+1 this would work.
Making it patch available.

> browseBlock.jsp does not generate "genstamp" property.
> ------------------------------------------------------
>
>                 Key: HADOOP-4613
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4613
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.18.0
>            Reporter: Konstantin Shvachko
>            Assignee: Johan Oskarsson
>             Fix For: 0.18.3
>
>         Attachments: HADOOP-4613.patch
>
>
> A link to a block replica display page on the web UI breaks with the following message: "Invalid input (genstamp absent)".
> The reason is that browsBlock.jsp sets "genstamp=" in the code two times out of three. 
> One spot in line #148 was missed by HADOOP-2656.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-4613) browseBlock.jsp does not generate "genstamp" property.

Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-4613?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tsz Wo (Nicholas), SZE updated HADOOP-4613:
-------------------------------------------

    Component/s: dfs
       Assignee: Johan Oskarsson

Konstantin, could you take a look at the patch?

> browseBlock.jsp does not generate "genstamp" property.
> ------------------------------------------------------
>
>                 Key: HADOOP-4613
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4613
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.18.0
>            Reporter: Konstantin Shvachko
>            Assignee: Johan Oskarsson
>             Fix For: 0.18.3
>
>         Attachments: HADOOP-4613.patch
>
>
> A link to a block replica display page on the web UI breaks with the following message: "Invalid input (genstamp absent)".
> The reason is that browsBlock.jsp sets "genstamp=" in the code two times out of three. 
> One spot in line #148 was missed by HADOOP-2656.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.