You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pig.apache.org by "Daniel Dai (JIRA)" <ji...@apache.org> on 2010/04/21 00:05:49 UTC
[jira] Created: (PIG-1384) Adding contrib javadoc to main Pig
javadoc
Adding contrib javadoc to main Pig javadoc
------------------------------------------
Key: PIG-1384
URL: https://issues.apache.org/jira/browse/PIG-1384
Project: Pig
Issue Type: Improvement
Components: documentation
Affects Versions: 0.7.0
Reporter: Daniel Dai
Assignee: Daniel Dai
Fix For: 0.7.0
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-1384) Adding contrib javadoc to main Pig
javadoc
Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daniel Dai updated PIG-1384:
----------------------------
Status: Resolved (was: Patch Available)
Hadoop Flags: [Reviewed]
Resolution: Fixed
Patch committed to both trunk and 0.7 branch.
> Adding contrib javadoc to main Pig javadoc
> ------------------------------------------
>
> Key: PIG-1384
> URL: https://issues.apache.org/jira/browse/PIG-1384
> Project: Pig
> Issue Type: Improvement
> Components: documentation
> Affects Versions: 0.7.0
> Reporter: Daniel Dai
> Assignee: Daniel Dai
> Fix For: 0.7.0
>
> Attachments: PIG-1384-0.7.patch, PIG-1384-trunk.patch, PIG-1384.apirel.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-1384) Adding contrib javadoc to main Pig
javadoc
Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daniel Dai updated PIG-1384:
----------------------------
Attachment: PIG-1384-0.7.patch
> Adding contrib javadoc to main Pig javadoc
> ------------------------------------------
>
> Key: PIG-1384
> URL: https://issues.apache.org/jira/browse/PIG-1384
> Project: Pig
> Issue Type: Improvement
> Components: documentation
> Affects Versions: 0.7.0
> Reporter: Daniel Dai
> Assignee: Daniel Dai
> Fix For: 0.7.0
>
> Attachments: PIG-1384-0.7.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (PIG-1384) Adding contrib javadoc to main Pig
javadoc
Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daniel Dai closed PIG-1384.
---------------------------
> Adding contrib javadoc to main Pig javadoc
> ------------------------------------------
>
> Key: PIG-1384
> URL: https://issues.apache.org/jira/browse/PIG-1384
> Project: Pig
> Issue Type: Improvement
> Components: documentation
> Affects Versions: 0.7.0
> Reporter: Daniel Dai
> Assignee: Daniel Dai
> Fix For: 0.7.0
>
> Attachments: PIG-1384-0.7.patch, PIG-1384-trunk.patch, PIG-1384.apirel.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-1384) Adding contrib javadoc to main Pig
javadoc
Posted by "Alan Gates (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12859965#action_12859965 ]
Alan Gates commented on PIG-1384:
---------------------------------
+1 Changes look good.
> Adding contrib javadoc to main Pig javadoc
> ------------------------------------------
>
> Key: PIG-1384
> URL: https://issues.apache.org/jira/browse/PIG-1384
> Project: Pig
> Issue Type: Improvement
> Components: documentation
> Affects Versions: 0.7.0
> Reporter: Daniel Dai
> Assignee: Daniel Dai
> Fix For: 0.7.0
>
> Attachments: PIG-1384-0.7.patch, PIG-1384-trunk.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-1384) Adding contrib javadoc to main Pig
javadoc
Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daniel Dai updated PIG-1384:
----------------------------
Attachment: PIG-1384.apirel.patch
One additional patch to change the api doc site link from absolute path to relative path. It is tiny and I don't want to create additional Jira for that.
> Adding contrib javadoc to main Pig javadoc
> ------------------------------------------
>
> Key: PIG-1384
> URL: https://issues.apache.org/jira/browse/PIG-1384
> Project: Pig
> Issue Type: Improvement
> Components: documentation
> Affects Versions: 0.7.0
> Reporter: Daniel Dai
> Assignee: Daniel Dai
> Fix For: 0.7.0
>
> Attachments: PIG-1384-0.7.patch, PIG-1384-trunk.patch, PIG-1384.apirel.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-1384) Adding contrib javadoc to main Pig
javadoc
Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daniel Dai updated PIG-1384:
----------------------------
Attachment: PIG-1384-trunk.patch
PIG-1384-0.7.patch
> Adding contrib javadoc to main Pig javadoc
> ------------------------------------------
>
> Key: PIG-1384
> URL: https://issues.apache.org/jira/browse/PIG-1384
> Project: Pig
> Issue Type: Improvement
> Components: documentation
> Affects Versions: 0.7.0
> Reporter: Daniel Dai
> Assignee: Daniel Dai
> Fix For: 0.7.0
>
> Attachments: PIG-1384-0.7.patch, PIG-1384-trunk.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-1384) Adding contrib javadoc to main Pig
javadoc
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12859181#action_12859181 ]
Hadoop QA commented on PIG-1384:
--------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12442360/PIG-1384-0.7.patch
against trunk revision 935968.
+1 @author. The patch does not contain any @author tags.
+0 tests included. The patch appears to be a documentation patch that doesn't require tests.
-1 javadoc. The javadoc tool appears to have generated 1 warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h7.grid.sp2.yahoo.net/296/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h7.grid.sp2.yahoo.net/296/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h7.grid.sp2.yahoo.net/296/console
This message is automatically generated.
> Adding contrib javadoc to main Pig javadoc
> ------------------------------------------
>
> Key: PIG-1384
> URL: https://issues.apache.org/jira/browse/PIG-1384
> Project: Pig
> Issue Type: Improvement
> Components: documentation
> Affects Versions: 0.7.0
> Reporter: Daniel Dai
> Assignee: Daniel Dai
> Fix For: 0.7.0
>
> Attachments: PIG-1384-0.7.patch, PIG-1384-trunk.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-1384) Adding contrib javadoc to main Pig
javadoc
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12859674#action_12859674 ]
Hadoop QA commented on PIG-1384:
--------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12442497/PIG-1384-trunk.patch
against trunk revision 936395.
+1 @author. The patch does not contain any @author tags.
+0 tests included. The patch appears to be a documentation patch that doesn't require tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/300/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/300/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/300/console
This message is automatically generated.
> Adding contrib javadoc to main Pig javadoc
> ------------------------------------------
>
> Key: PIG-1384
> URL: https://issues.apache.org/jira/browse/PIG-1384
> Project: Pig
> Issue Type: Improvement
> Components: documentation
> Affects Versions: 0.7.0
> Reporter: Daniel Dai
> Assignee: Daniel Dai
> Fix For: 0.7.0
>
> Attachments: PIG-1384-0.7.patch, PIG-1384-trunk.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-1384) Adding contrib javadoc to main Pig
javadoc
Posted by "Olga Natkovich (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12860012#action_12860012 ]
Olga Natkovich commented on PIG-1384:
-------------------------------------
+1 on the latest patch
> Adding contrib javadoc to main Pig javadoc
> ------------------------------------------
>
> Key: PIG-1384
> URL: https://issues.apache.org/jira/browse/PIG-1384
> Project: Pig
> Issue Type: Improvement
> Components: documentation
> Affects Versions: 0.7.0
> Reporter: Daniel Dai
> Assignee: Daniel Dai
> Fix For: 0.7.0
>
> Attachments: PIG-1384-0.7.patch, PIG-1384-trunk.patch, PIG-1384.apirel.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-1384) Adding contrib javadoc to main Pig
javadoc
Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daniel Dai updated PIG-1384:
----------------------------
Status: Patch Available (was: Open)
Hudson may cry loud since there are so many new javadoc warnings, especially in piggybank.
> Adding contrib javadoc to main Pig javadoc
> ------------------------------------------
>
> Key: PIG-1384
> URL: https://issues.apache.org/jira/browse/PIG-1384
> Project: Pig
> Issue Type: Improvement
> Components: documentation
> Affects Versions: 0.7.0
> Reporter: Daniel Dai
> Assignee: Daniel Dai
> Fix For: 0.7.0
>
> Attachments: PIG-1384-0.7.patch, PIG-1384-trunk.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-1384) Adding contrib javadoc to main Pig
javadoc
Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daniel Dai updated PIG-1384:
----------------------------
Attachment: (was: PIG-1384-0.7.patch)
> Adding contrib javadoc to main Pig javadoc
> ------------------------------------------
>
> Key: PIG-1384
> URL: https://issues.apache.org/jira/browse/PIG-1384
> Project: Pig
> Issue Type: Improvement
> Components: documentation
> Affects Versions: 0.7.0
> Reporter: Daniel Dai
> Assignee: Daniel Dai
> Fix For: 0.7.0
>
> Attachments: PIG-1384-0.7.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-1384) Adding contrib javadoc to main Pig
javadoc
Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daniel Dai updated PIG-1384:
----------------------------
Status: Patch Available (was: Open)
Definitely agree. Never though about that before. Attach the patches again.
> Adding contrib javadoc to main Pig javadoc
> ------------------------------------------
>
> Key: PIG-1384
> URL: https://issues.apache.org/jira/browse/PIG-1384
> Project: Pig
> Issue Type: Improvement
> Components: documentation
> Affects Versions: 0.7.0
> Reporter: Daniel Dai
> Assignee: Daniel Dai
> Fix For: 0.7.0
>
> Attachments: PIG-1384-0.7.patch, PIG-1384-trunk.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-1384) Adding contrib javadoc to main Pig
javadoc
Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daniel Dai updated PIG-1384:
----------------------------
Attachment: (was: PIG-1384-trunk.patch)
> Adding contrib javadoc to main Pig javadoc
> ------------------------------------------
>
> Key: PIG-1384
> URL: https://issues.apache.org/jira/browse/PIG-1384
> Project: Pig
> Issue Type: Improvement
> Components: documentation
> Affects Versions: 0.7.0
> Reporter: Daniel Dai
> Assignee: Daniel Dai
> Fix For: 0.7.0
>
> Attachments: PIG-1384-0.7.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-1384) Adding contrib javadoc to main Pig
javadoc
Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daniel Dai updated PIG-1384:
----------------------------
Status: Open (was: Patch Available)
> Adding contrib javadoc to main Pig javadoc
> ------------------------------------------
>
> Key: PIG-1384
> URL: https://issues.apache.org/jira/browse/PIG-1384
> Project: Pig
> Issue Type: Improvement
> Components: documentation
> Affects Versions: 0.7.0
> Reporter: Daniel Dai
> Assignee: Daniel Dai
> Fix For: 0.7.0
>
> Attachments: PIG-1384-0.7.patch, PIG-1384-trunk.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-1384) Adding contrib javadoc to main Pig
javadoc
Posted by "Alan Gates (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12859522#action_12859522 ]
Alan Gates commented on PIG-1384:
---------------------------------
I don't think we want 'ant javadoc' to build all of the contrib javadocs. I have three reasons for this:
# In general we have been keeping contrib builds out of default pig builds, so that users can build pig code and docs without worrying about contrib.
# We worked hard to get all of the javadoc warnings out of main pig code. If we put 298 warnings in there from contrib then we'll mess up hudson and make it impossible to tell when we're adding real warnings to core Pig javadocs.
# Trying to build all of the docs at once runs out of memory on my mac, though it works fine on my Linux box. So it seems that building all these docs takes more memory than your average developer environment JVM is set up with. We don't want to force people to change around their JVM just to build the javadocs.
This can be done by moving {{javadoc}} target in this patch to a new target, {{javadoc-all}}. The old {{javadoc}} target can then be restored as is. The {{docs}} target can then be changed to call {{javadoc-all}} instead of {{javadoc}}. This way developers and hudson can still just build the javadoc for Pig, while the release process (which uses the {{tar}} target which in turn uses the {{docs}} target) can build all of the docs.
> Adding contrib javadoc to main Pig javadoc
> ------------------------------------------
>
> Key: PIG-1384
> URL: https://issues.apache.org/jira/browse/PIG-1384
> Project: Pig
> Issue Type: Improvement
> Components: documentation
> Affects Versions: 0.7.0
> Reporter: Daniel Dai
> Assignee: Daniel Dai
> Fix For: 0.7.0
>
> Attachments: PIG-1384-0.7.patch, PIG-1384-trunk.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-1384) Adding contrib javadoc to main Pig
javadoc
Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daniel Dai updated PIG-1384:
----------------------------
Attachment: PIG-1384-trunk.patch
> Adding contrib javadoc to main Pig javadoc
> ------------------------------------------
>
> Key: PIG-1384
> URL: https://issues.apache.org/jira/browse/PIG-1384
> Project: Pig
> Issue Type: Improvement
> Components: documentation
> Affects Versions: 0.7.0
> Reporter: Daniel Dai
> Assignee: Daniel Dai
> Fix For: 0.7.0
>
> Attachments: PIG-1384-0.7.patch, PIG-1384-trunk.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.