You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by "deniskuzZ (via GitHub)" <gi...@apache.org> on 2024/05/27 09:52:29 UTC
Re: [PR] HIVE-28118: Hive Insert Into S3 with Viewfs overload scheme fails wit… [hive]
deniskuzZ commented on code in PR #5137:
URL: https://github.com/apache/hive/pull/5137#discussion_r1615812933
##########
ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java:
##########
@@ -5266,7 +5266,8 @@ static private boolean needToCopy(final HiveConf conf, Path srcf, Path destf, Fi
try {
return srcHdfsEncryptionShim != null
&& destHdfsEncryptionShim != null
- && (srcHdfsEncryptionShim.isPathEncrypted(srcf) || destHdfsEncryptionShim.isPathEncrypted(destf))
+ && ((srcFs.exists(srcf) && srcHdfsEncryptionShim.isPathEncrypted(srcf))
Review Comment:
why do you need extra brackets for `&&` operands?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org