[GitHub] [nuttx] pkarashchenko commented on a diff in pull request #8779: arch: Rename up_[early]serialinit to [arm64|riscv|x86_64][early]serialinit

["pkarashchenko (via GitHub)" <gi...@apache.org>]

pkarashchenko commented on code in PR #8779:
URL: https://github.com/apache/nuttx/pull/8779#discussion_r1133315730


##########
arch/arm64/src/fvp-v8r/fvp_lowputc.S:
##########
@@ -50,24 +50,6 @@
  * Public Functions
  ****************************************************************************/
 
-/* PL011 UART initialization
- * xb: register which contains the UART base address
- * c: scratch register number
- */
-
-GTEXT(up_earlyserialinit)
-SECTION_FUNC(text, up_earlyserialinit)

Review Comment:
   I do not fully understand why this is removed and not renamed. Could you please make a short explanation here?



##########
arch/x86/src/qemu/qemu_serial.c:
##########
@@ -93,13 +93,13 @@ int up_putc(int ch)
 #ifdef USE_EARLYSERIALINIT
 void x86_earlyserialinit(void)
 {
-  up_earlyserialinit();
+  u16550_earlyserialinit();
 }
 #endif
 
 #ifdef USE_SERIALDRIVER
 void x86_serialinit(void)
 {
-  up_serialinit();
+  u16550_serialinit();

Review Comment:
   Please add newline at the end of file



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org