[GitHub] [kafka] divijvaidya commented on pull request #13220: Kafka 14253

["divijvaidya (via GitHub)" <gi...@apache.org>]

divijvaidya commented on PR #13220:
URL: https://github.com/apache/kafka/pull/13220#issuecomment-1425505624

   Hey @ouyangnengda 
   
   I see that this is your first contribution to Kafka. Thank you for your interest in the project!
   
   Since you are new to the community, let me fill you in with some best practices around submitting PRs:
   1. First, [assign the JIRA to yourself](https://issues.apache.org/jira/browse/KAFKA-14253). This helps ensure that multiple people aren't working on same JIRA and hence, don't end up spending duplicate effort. 
   2.The name of the PR begins with the JIRA follower by `:` e.g. "KAFKA-14253: Add the number of members in the assignment log to improve readability". A workflow in the background will automatically add the PR to JIRA if you follow this format.
   3. You will notice that the build is failing here. Although it doesn't seem related to your changes, but it would be nice if you could add a "testing" section in the description of the PR and mention that you ran unitTests and intergTests locally and it works for you. I usually do it by running `./gradlew unitTest` and `./gradlew integrationTest`.
   
   Other than the above, the code change itself looks good to me. I will add an acceptance (and we will have to ping a committer to merge this) once you have made the changes I request above.
   
   Cheers!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org