You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/06/27 22:33:23 UTC

[GitHub] [flink] NicoK commented on issue #8877: [FLINK-12984][metrics] only call Histogram#getStatistics() once where possible

NicoK commented on issue #8877: [FLINK-12984][metrics] only call Histogram#getStatistics() once where possible
URL: https://github.com/apache/flink/pull/8877#issuecomment-506535212
 
 
   @StephanEwen yes, indirectly: I needed the (test-scope, test-jar) dependency to have a common test class `AbstractHistogramTest` and this needed to be in `flink-runtime` because `DescriptiveStatisticsHistogram` lives there.
   
   FYI: There was already a test-scope (normal jar) dependency on `flink-runtime`, presumably for similar reasons. I guess, the reason to put it into `flink-runtime` was to have some default to be available at any time without extra dependencies for the user, and also because our latency markers use the `DescriptiveStatisticsHistogram`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services