You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Nitiraj Rathore <ni...@gmail.com> on 2017/05/09 10:07:32 UTC
Review Request 59087: Hive View 2.0 and 1.5 : The downloaded file
name will
be shown as ____.csv when we download the query result with the unicode name
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59087/
-----------------------------------------------------------
Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
Bugs: AMBARI-20962
https://issues.apache.org/jira/browse/AMBARI-20962
Repository: ambari
Description
-------
made fileName as path param instead of query param. Now downloaded file's name preserves unicode characters.
Diffs
-----
contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/jobs/JobService.java 5fa96bb0a8
contrib/views/hive-next/src/main/resources/ui/hive-web/app/controllers/index.js 8250dbbd84
contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/jobs/JobService.java f2e4ee9b6c
contrib/views/hive20/src/main/resources/ui/app/adapters/job.js e40c0ba4ac
Diff: https://reviews.apache.org/r/59087/diff/1/
Testing
-------
Done testing on various browsers manually.
Thanks,
Nitiraj Rathore
Re: Review Request 59087: Hive View 2.0 and 1.5 : The downloaded file
name
will be shown as ____.csv when we download the query result with the
unicode name
Posted by Pallav Kulshreshtha <pa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59087/#review174290
-----------------------------------------------------------
Ship it!
Ship It!
- Pallav Kulshreshtha
On May 9, 2017, 10:07 a.m., Nitiraj Rathore wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59087/
> -----------------------------------------------------------
>
> (Updated May 9, 2017, 10:07 a.m.)
>
>
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
>
>
> Bugs: AMBARI-20962
> https://issues.apache.org/jira/browse/AMBARI-20962
>
>
> Repository: ambari
>
>
> Description
> -------
>
> made fileName as path param instead of query param. Now downloaded file's name preserves unicode characters.
>
>
> Diffs
> -----
>
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/jobs/JobService.java 5fa96bb0a8
> contrib/views/hive-next/src/main/resources/ui/hive-web/app/controllers/index.js 8250dbbd84
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/jobs/JobService.java f2e4ee9b6c
> contrib/views/hive20/src/main/resources/ui/app/adapters/job.js e40c0ba4ac
>
>
> Diff: https://reviews.apache.org/r/59087/diff/1/
>
>
> Testing
> -------
>
> Done testing on various browsers manually.
>
>
> Thanks,
>
> Nitiraj Rathore
>
>
Re: Review Request 59087: Hive View 2.0 and 1.5 : The downloaded file
name
will be shown as ____.csv when we download the query result with the
unicode name
Posted by Gaurav Nagar <gn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59087/#review174286
-----------------------------------------------------------
Ship it!
Ship It!
- Gaurav Nagar
On May 9, 2017, 10:07 a.m., Nitiraj Rathore wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59087/
> -----------------------------------------------------------
>
> (Updated May 9, 2017, 10:07 a.m.)
>
>
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
>
>
> Bugs: AMBARI-20962
> https://issues.apache.org/jira/browse/AMBARI-20962
>
>
> Repository: ambari
>
>
> Description
> -------
>
> made fileName as path param instead of query param. Now downloaded file's name preserves unicode characters.
>
>
> Diffs
> -----
>
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/jobs/JobService.java 5fa96bb0a8
> contrib/views/hive-next/src/main/resources/ui/hive-web/app/controllers/index.js 8250dbbd84
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/jobs/JobService.java f2e4ee9b6c
> contrib/views/hive20/src/main/resources/ui/app/adapters/job.js e40c0ba4ac
>
>
> Diff: https://reviews.apache.org/r/59087/diff/1/
>
>
> Testing
> -------
>
> Done testing on various browsers manually.
>
>
> Thanks,
>
> Nitiraj Rathore
>
>