[GitHub] [pulsar] chairmank opened a new pull request #3929: [3928][tiered-storage] Include java-xmlbuilder in tiered-storage-jcloud NAR

[GitBox <gi...@apache.org>]

chairmank opened a new pull request #3929: [3928][tiered-storage] Include java-xmlbuilder in tiered-storage-jcloud NAR
URL: https://github.com/apache/pulsar/pull/3929
 
 
   In the POM file for tiered-storage-jcloud, the dependency on
   com.jamesmurty.utils/java-xmlbuilder was marked with test scope, but in
   fact this dependency is needed during normal use. This commit changes
   the POM file so that the java-xmlbuilder dependency is packaged in the
   NAR file.
   
   Fixes #3928.
   
   ### Verifying this change
   
   I am not sure how to test this change. I don't know the implications of changing this dependency. Maybe the java-xmlbuilder dependency was marked as "test" for a specific reason, and my change will break something else.
   
   The NAR file builds when I run `mvn package`. When I deployed it to a test cluster running pulsar 2.3.0, I did not see the errors that were reported in #3928.
   
   ### Does this pull request potentially affect one of the following parts:
   
   *If `yes` was chosen, please highlight the changes*
   
     - Dependencies (does it add or upgrade a dependency): yes
     - The public API: no
     - The schema: no
     - The default values of configurations: no
     - The wire protocol: no
     - The rest endpoints: no
     - The admin cli options: no
     - Anything that affects deployment: don't know
   
   ### Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? not applicable
     - If a feature is not applicable for documentation, explain why?
     - If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services