You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Dmitro Lisnichenko <dl...@hortonworks.com> on 2014/10/20 20:42:51 UTC
Review Request 26947: log4j does not get used by hadoop as settings
are present in hadoop.config.sh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26947/
-----------------------------------------------------------
Review request for Ambari, Andrew Onischuk and Mahadev Konar.
Bugs: AMBARI-7119
https://issues.apache.org/jira/browse/AMBARI-7119
Repository: ambari
Description
-------
PROBLEM: log4j settings made via Ambari update the log4j file but do not take
any affect when restarting HDFS. It seems there are hardcoded settings in
/usr/lib/hadoop/libexec/hadoop-config.sh such as this at line 221:
HADOOP_OPTS="$HADOOP_OPTS -Dhadoop.root.logger=$
{HADOOP_ROOT_LOGGER:-INFO,console}
Diffs
-----
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/configuration/hadoop-env.xml a2954b7
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/configuration/hadoop-env.xml 8865d18
ambari-server/src/main/resources/stacks/HDP/2.2/services/HDFS/configuration/hadoop-env.xml 384a5f6
Diff: https://reviews.apache.org/r/26947/diff/
Testing
-------
not applicable
Thanks,
Dmitro Lisnichenko
Re: Review Request 26947: log4j does not get used by hadoop as
settings are present in hadoop.config.sh
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
> On Oct. 21, 2014, 2:27 a.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/configuration/hadoop-env.xml, line 208
> > <https://reviews.apache.org/r/26947/diff/1/?file=726072#file726072line208>
> >
> > Regarding the Testing comment as "Not Applicable"; did this work as expected after restarting HDFS on a cluster?
This was tested via deploying cluster and checking that hdfs components are running as expected. Also checked that AMBARI-7803
issue did not show up. Should any additional tests be performed?
- Dmitro
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26947/#review57527
-----------------------------------------------------------
On Oct. 20, 2014, 6:42 p.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26947/
> -----------------------------------------------------------
>
> (Updated Oct. 20, 2014, 6:42 p.m.)
>
>
> Review request for Ambari, Andrew Onischuk and Mahadev Konar.
>
>
> Bugs: AMBARI-7119
> https://issues.apache.org/jira/browse/AMBARI-7119
>
>
> Repository: ambari
>
>
> Description
> -------
>
> PROBLEM: log4j settings made via Ambari update the log4j file but do not take
> any affect when restarting HDFS. It seems there are hardcoded settings in
> /usr/lib/hadoop/libexec/hadoop-config.sh such as this at line 221:
>
> HADOOP_OPTS="$HADOOP_OPTS -Dhadoop.root.logger=$
> {HADOOP_ROOT_LOGGER:-INFO,console}
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/configuration/hadoop-env.xml a2954b7
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/configuration/hadoop-env.xml 8865d18
> ambari-server/src/main/resources/stacks/HDP/2.2/services/HDFS/configuration/hadoop-env.xml 384a5f6
>
> Diff: https://reviews.apache.org/r/26947/diff/
>
>
> Testing
> -------
>
> not applicable
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 26947: log4j does not get used by hadoop as
settings are present in hadoop.config.sh
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
> On Oct. 21, 2014, 2:27 a.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/configuration/hadoop-env.xml, line 208
> > <https://reviews.apache.org/r/26947/diff/1/?file=726072#file726072line208>
> >
> > Regarding the Testing comment as "Not Applicable"; did this work as expected after restarting HDFS on a cluster?
>
> Dmitro Lisnichenko wrote:
> This was tested via deploying cluster and checking that hdfs components are running as expected. Also checked that AMBARI-7803
> issue did not show up. Should any additional tests be performed?
Under "not applicable" I mean that patch does not affect any code that is covered by unit tests. That's why I did not post 'mvn clean test' results.
- Dmitro
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26947/#review57527
-----------------------------------------------------------
On Oct. 20, 2014, 6:42 p.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26947/
> -----------------------------------------------------------
>
> (Updated Oct. 20, 2014, 6:42 p.m.)
>
>
> Review request for Ambari, Andrew Onischuk and Mahadev Konar.
>
>
> Bugs: AMBARI-7119
> https://issues.apache.org/jira/browse/AMBARI-7119
>
>
> Repository: ambari
>
>
> Description
> -------
>
> PROBLEM: log4j settings made via Ambari update the log4j file but do not take
> any affect when restarting HDFS. It seems there are hardcoded settings in
> /usr/lib/hadoop/libexec/hadoop-config.sh such as this at line 221:
>
> HADOOP_OPTS="$HADOOP_OPTS -Dhadoop.root.logger=$
> {HADOOP_ROOT_LOGGER:-INFO,console}
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/configuration/hadoop-env.xml a2954b7
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/configuration/hadoop-env.xml 8865d18
> ambari-server/src/main/resources/stacks/HDP/2.2/services/HDFS/configuration/hadoop-env.xml 384a5f6
>
> Diff: https://reviews.apache.org/r/26947/diff/
>
>
> Testing
> -------
>
> not applicable
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 26947: log4j does not get used by hadoop as
settings are present in hadoop.config.sh
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26947/#review57527
-----------------------------------------------------------
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/configuration/hadoop-env.xml
<https://reviews.apache.org/r/26947/#comment98259>
Regarding the Testing comment as "Not Applicable"; did this work as expected after restarting HDFS on a cluster?
- Alejandro Fernandez
On Oct. 20, 2014, 6:42 p.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26947/
> -----------------------------------------------------------
>
> (Updated Oct. 20, 2014, 6:42 p.m.)
>
>
> Review request for Ambari, Andrew Onischuk and Mahadev Konar.
>
>
> Bugs: AMBARI-7119
> https://issues.apache.org/jira/browse/AMBARI-7119
>
>
> Repository: ambari
>
>
> Description
> -------
>
> PROBLEM: log4j settings made via Ambari update the log4j file but do not take
> any affect when restarting HDFS. It seems there are hardcoded settings in
> /usr/lib/hadoop/libexec/hadoop-config.sh such as this at line 221:
>
> HADOOP_OPTS="$HADOOP_OPTS -Dhadoop.root.logger=$
> {HADOOP_ROOT_LOGGER:-INFO,console}
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/configuration/hadoop-env.xml a2954b7
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/configuration/hadoop-env.xml 8865d18
> ambari-server/src/main/resources/stacks/HDP/2.2/services/HDFS/configuration/hadoop-env.xml 384a5f6
>
> Diff: https://reviews.apache.org/r/26947/diff/
>
>
> Testing
> -------
>
> not applicable
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 26947: log4j does not get used by hadoop as
settings are present in hadoop.config.sh
Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26947/#review57575
-----------------------------------------------------------
Ship it!
Ship It!
- Andrew Onischuk
On Oct. 20, 2014, 6:42 p.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26947/
> -----------------------------------------------------------
>
> (Updated Oct. 20, 2014, 6:42 p.m.)
>
>
> Review request for Ambari, Andrew Onischuk and Mahadev Konar.
>
>
> Bugs: AMBARI-7119
> https://issues.apache.org/jira/browse/AMBARI-7119
>
>
> Repository: ambari
>
>
> Description
> -------
>
> PROBLEM: log4j settings made via Ambari update the log4j file but do not take
> any affect when restarting HDFS. It seems there are hardcoded settings in
> /usr/lib/hadoop/libexec/hadoop-config.sh such as this at line 221:
>
> HADOOP_OPTS="$HADOOP_OPTS -Dhadoop.root.logger=$
> {HADOOP_ROOT_LOGGER:-INFO,console}
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/configuration/hadoop-env.xml a2954b7
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/configuration/hadoop-env.xml 8865d18
> ambari-server/src/main/resources/stacks/HDP/2.2/services/HDFS/configuration/hadoop-env.xml 384a5f6
>
> Diff: https://reviews.apache.org/r/26947/diff/
>
>
> Testing
> -------
>
> not applicable
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>