You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/08/24 10:07:02 UTC
[GitHub] [camel] klease opened a new pull request, #8212: CAMEL-18355: Fix bug when both proxy and basic authentication credent…
klease opened a new pull request, #8212:
URL: https://github.com/apache/camel/pull/8212
…ials provided
Add helper class to manage credentials to set on the HttpClient.
Add a unit test reproducing the issue.
<!-- Uncomment and fill this section if your PR is not trivial
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] If you're unsure, you can format the pull request title like `[CAMEL-XXX] Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the appropriate JIRA issue.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean install -Psourcecheck` in your module with source check enabled to make sure basic checks pass and there are no checkstyle violations. A more thorough check will be performed on your pull request automatically.
Below are the contribution guidelines:
https://github.com/apache/camel/blob/main/CONTRIBUTING.md
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #8212: CAMEL-18355: Fix bug when both proxy and basic authentication credent…
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #8212:
URL: https://github.com/apache/camel/pull/8212#issuecomment-1225508119
:warning: This PR changes Camel components and will be tested automatically.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #8212: CAMEL-18355: Fix bug when both proxy and basic authentication credent…
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #8212:
URL: https://github.com/apache/camel/pull/8212#issuecomment-1225573246
:heavy_check_mark: Finished component verification: 0 component(s) test failed out of **1 component(s) tested**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] klease merged pull request #8212: CAMEL-18355: Fix bug when both proxy and basic authentication credent…
Posted by GitBox <gi...@apache.org>.
klease merged PR #8212:
URL: https://github.com/apache/camel/pull/8212
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #8212: CAMEL-18355: Fix bug when both proxy and basic authentication credent…
Posted by GitBox <gi...@apache.org>.
davsclaus commented on PR #8212:
URL: https://github.com/apache/camel/pull/8212#issuecomment-1226017941
If you do a hot reload updating routes that used http, then the map could be growing forever causing a memory leak.
A better approach is to store that help as a instance on the http component, then its private to this component. You can create the helper in the doInit method etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #8212: CAMEL-18355: Fix bug when both proxy and basic authentication credent…
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #8212:
URL: https://github.com/apache/camel/pull/8212#issuecomment-1227390522
:heavy_check_mark: Finished component verification: 0 component(s) test failed out of **1 component(s) tested**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #8212: CAMEL-18355: Fix bug when both proxy and basic authentication credent…
Posted by GitBox <gi...@apache.org>.
davsclaus commented on PR #8212:
URL: https://github.com/apache/camel/pull/8212#issuecomment-1227279063
Yeah if you think this is better and have time to do so
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] klease commented on pull request #8212: CAMEL-18355: Fix bug when both proxy and basic authentication credent…
Posted by GitBox <gi...@apache.org>.
klease commented on PR #8212:
URL: https://github.com/apache/camel/pull/8212#issuecomment-1225641725
> The HttpCredentialsHelper is static which means you cant have 2+ http components in the same JVM with different settings.
True. I'll address that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #8212: CAMEL-18355: Fix bug when both proxy and basic authentication credent…
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #8212:
URL: https://github.com/apache/camel/pull/8212#issuecomment-1225984706
:heavy_check_mark: Finished component verification: 0 component(s) test failed out of **1 component(s) tested**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] klease commented on pull request #8212: CAMEL-18355: Fix bug when both proxy and basic authentication credent…
Posted by GitBox <gi...@apache.org>.
klease commented on PR #8212:
URL: https://github.com/apache/camel/pull/8212#issuecomment-1227262141
Thanks for the feedback Claus.
There isn't a doInit method on HttpComponent so I just create it in the method which creates the ClientBuilder and pass it to the private methods creating the configurers.
I also had to modify HttpComponentVerifierExtension.java which creates a ClientBuilder.
Perhaps it would be better to move the Helper to the main http package and give it package visiblity following these changes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #8212: CAMEL-18355: Fix bug when both proxy and basic authentication credent…
Posted by GitBox <gi...@apache.org>.
davsclaus commented on PR #8212:
URL: https://github.com/apache/camel/pull/8212#issuecomment-1225554286
The HttpCredentialsHelper is static which means you cant have 2+ http components in the same JVM with different settings.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org