You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2021/01/19 14:20:37 UTC

[GitHub] [incubator-dolphinscheduler] CalvinKirs commented on a change in pull request #4491: [Feature][dolphinscheduler-api] ProcessDefinitionController save API returns ProcessDefinitionId #4481

CalvinKirs commented on a change in pull request #4491:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/4491#discussion_r560208908



##########
File path: dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/ProcessDefinitionServiceImpl.java
##########
@@ -888,8 +887,8 @@ private boolean checkAndImportProcessDefinition(User loginUser, String currentPr
 
         //create process definition
         Integer processDefinitionId =
-                Objects.isNull(createProcessResult.get(PROCESSDEFINITIONID))
-                        ? null : Integer.parseInt(createProcessResult.get(PROCESSDEFINITIONID).toString());
+                Objects.isNull(createProcessResult.get(Constants.DATA_LIST))

Review comment:
       I think it would be better to keep the original one. PROCESSDEFINITIONID clearly expresses the field key to be obtained here.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org