You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/08/22 18:39:03 UTC

[GitHub] [superset] justinpark opened a new pull request, #21153: fix(sqllab): missing zero values while copy-to-clipboard

justinpark opened a new pull request, #21153:
URL: https://github.com/apache/superset/pull/21153

   ### SUMMARY
   Since JS returns false for zero values, following value existence statement `data[i][key]` skips the zero values.
   
   https://github.com/apache/superset/blob/0bf4e56dc3e129d2b9239f055212249ba95521e4/superset-frontend/src/utils/common.js#L100-L106
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   https://user-images.githubusercontent.com/1392866/185994528-0f50d879-d05b-48b5-a9ee-641e9efa7bd9.mov
   
   ### TESTING INSTRUCTIONS
   
   1. Go to Sql Lab
   2. Run the following query
   ```
   SELECT 'copy to clipboard',
           0 as zero,
           1 as one
   ```
   3. "Copy to clipboard"
   4. Paste to a note
   
   ### ADDITIONAL INFORMATION
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov[bot] commented on pull request #21153: fix(sqllab): missing zero values while copy-to-clipboard

Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #21153:
URL: https://github.com/apache/superset/pull/21153#issuecomment-1222830034

   # [Codecov](https://codecov.io/gh/apache/superset/pull/21153?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#21153](https://codecov.io/gh/apache/superset/pull/21153?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ce68697) into [master](https://codecov.io/gh/apache/superset/commit/0bf4e56dc3e129d2b9239f055212249ba95521e4?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0bf4e56) will **not change** coverage.
   > The diff coverage is `100.00%`.
   
   ```diff
   @@           Coverage Diff           @@
   ##           master   #21153   +/-   ##
   =======================================
     Coverage   66.16%   66.16%           
   =======================================
     Files        1773     1773           
     Lines       67689    67689           
     Branches     7218     7218           
   =======================================
     Hits        44786    44786           
     Misses      21059    21059           
     Partials     1844     1844           
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | javascript | `52.12% <100.00%> (ø)` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/21153?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [superset-frontend/src/utils/common.js](https://codecov.io/gh/apache/superset/pull/21153/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL2NvbW1vbi5qcw==) | `90.00% <100.00%> (ø)` | |
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] ktmud merged pull request #21153: fix(sqllab): missing zero values while copy-to-clipboard

Posted by GitBox <gi...@apache.org>.
ktmud merged PR #21153:
URL: https://github.com/apache/superset/pull/21153


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org