You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Gaurav Aradhye <ga...@clogeny.com> on 2014/12/01 12:14:18 UTC
Review Request 28549: CLOUDSTACK-7993: Code enhancement -
test_egress_fw_rules.py - Removing unncessary waits
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28549/
-----------------------------------------------------------
Review request for cloudstack and SrikanteswaraRao Talluri.
Bugs: CLOUDSTACK-7993
https://issues.apache.org/jira/browse/CLOUDSTACK-7993
Repository: cloudstack-git
Description
-------
All test cases in this test suite wait for vm expungement time period after destroying VMs. It is not necessary as now th VM is destroyed by default from Marvin with expunge parameter as True, hence it will be immediately destroyed and expunged.
Diffs
-----
test/integration/component/test_egress_fw_rules.py 0122e4f
Diff: https://reviews.apache.org/r/28549/diff/
Testing
-------
Yes.
Thanks,
Gaurav Aradhye
Re: Review Request 28549: CLOUDSTACK-7993: Code enhancement -
test_egress_fw_rules.py - Removing unncessary waits
Posted by SrikanteswaraRao Talluri <sr...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28549/#review63517
-----------------------------------------------------------
Ship it!
6a2c18a989a081cdf79dc8453b488b14a72cdd01 master
3d279bbb190f9907a80cc5d3f8142b3f9eb90f01 4.5
- SrikanteswaraRao Talluri
On Dec. 1, 2014, 11:14 a.m., Gaurav Aradhye wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28549/
> -----------------------------------------------------------
>
> (Updated Dec. 1, 2014, 11:14 a.m.)
>
>
> Review request for cloudstack and SrikanteswaraRao Talluri.
>
>
> Bugs: CLOUDSTACK-7993
> https://issues.apache.org/jira/browse/CLOUDSTACK-7993
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> All test cases in this test suite wait for vm expungement time period after destroying VMs. It is not necessary as now th VM is destroyed by default from Marvin with expunge parameter as True, hence it will be immediately destroyed and expunged.
>
>
> Diffs
> -----
>
> test/integration/component/test_egress_fw_rules.py 0122e4f
>
> Diff: https://reviews.apache.org/r/28549/diff/
>
>
> Testing
> -------
>
> Yes.
>
>
> Thanks,
>
> Gaurav Aradhye
>
>