You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Mark Miller (JIRA)" <ji...@apache.org> on 2015/12/09 16:01:11 UTC
[jira] [Comment Edited] (SOLR-8367) The new LIR 'all replicas
participate' failsafe code needs to be improved.
[ https://issues.apache.org/jira/browse/SOLR-8367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15048768#comment-15048768 ]
Mark Miller edited comment on SOLR-8367 at 12/9/15 3:00 PM:
------------------------------------------------------------
bq. in SolrCore that could probably be log.debug or even trace.
System.out is not allowed in SolrCore, I just have not cleaned up yet.
bq. If you're fixing shard count to 2 in the test, do we still want to createCollection(testCollectionName, 1, 3, 1); for three shards?
Yes, create api uses 3 shards (there is a control jetty).
bq. What happens when you send an update FROMLEADER to the one that happens to be the leader?
See the conflict exception we check for.
bq. Also, why are we using decreasing versions?
Because it doesn't matter for this test.
was (Author: markrmiller@gmail.com):
bq. in SolrCore that could probably be log.debug or even trace.
System.out is not allowed in SolrCore, I just have not cleaned up yet.
bq. If you're fixing shard count to 2 in the test, do we still want to createCollection(testCollectionName, 1, 3, 1); for three shards?
Yes, create api uses 3 shards.
bq. What happens when you send an update FROMLEADER to the one that happens to be the leader?
See the conflict exception we check for.
bq. Also, why are we using decreasing versions?
Because it doesn't matter for this test.
> The new LIR 'all replicas participate' failsafe code needs to be improved.
> --------------------------------------------------------------------------
>
> Key: SOLR-8367
> URL: https://issues.apache.org/jira/browse/SOLR-8367
> Project: Solr
> Issue Type: Bug
> Reporter: Mark Miller
> Assignee: Mark Miller
> Attachments: SOLR-8367.patch, SOLR-8367.patch, SOLR-8367.patch
>
>
> For one, it currently only kicks in the first attempted leader. If it's another replica that is stuck in LIR, it won't help.
> Second, when we attempt to be leader, knowing we might fail due to LIR, we should not put other replicas into recovery if they fail to sync with us - not until we know we will actually be leader.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org