You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@airflow.apache.org by Verdan Mahmood <ve...@gmail.com> on 2018/07/25 12:06:13 UTC

Flaky test case: test_mark_success_no_kill

Hi,

The test "test_mark_success_no_kill" is flaky and fails most of the time
when running with Python 3.5 and Postgres backend, causing builds to be
failed.
This has already been skipped for MySQL backend.

Do we know if someone is working on trying to fix this or can we skip this
for now for Postgres backend as well?

Best,
*Verdan Mahmood*

Re: Flaky test case: test_mark_success_no_kill

Posted by Taylor Edmiston <te...@gmail.com>.
Here's a PR + Jira issue :)

https://github.com/apache/incubator-airflow/pull/3642 <https://github.com/apache/incubator-airflow/pull/3642>

https://issues.apache.org/jira/browse/AIRFLOW-2801 <https://issues.apache.org/jira/browse/AIRFLOW-2801>

I included an example of the CI error in the Jira issue.

Taylor

Taylor Edmiston
Blog <https://blog.tedmiston.com/> | CV <https://stackoverflow.com/cv/taylor> | LinkedIn <https://www.linkedin.com/in/tedmiston/> | AngelList <https://angel.co/taylor> | Stack Overflow <https://stackoverflow.com/users/149428/taylor-edmiston>


> On Jul 25, 2018, at 1:38 PM, Taylor Edmiston <te...@gmail.com> wrote:
> 
> Good catch.
> 
> I just made a branch to skip this test on PostgreSQL.  Working on an issue and PR now.
> 
> https://github.com/apache/incubator-airflow/compare/master...astronomerio:test_mark_success_no_kill-postgresql <https://github.com/apache/incubator-airflow/compare/master...astronomerio:test_mark_success_no_kill-postgresql>
> 
> Taylor Edmiston
> Blog <https://blog.tedmiston.com/> | CV <https://stackoverflow.com/cv/taylor> | LinkedIn <https://www.linkedin.com/in/tedmiston/> | AngelList <https://angel.co/taylor> | Stack Overflow <https://stackoverflow.com/users/149428/taylor-edmiston>
> 
> 
>> On Jul 25, 2018, at 8:06 AM, Verdan Mahmood <verdan.mahmood@gmail.com <ma...@gmail.com>> wrote:
>> 
>> Hi,
>> 
>> The test "test_mark_success_no_kill" is flaky and fails most of the time
>> when running with Python 3.5 and Postgres backend, causing builds to be
>> failed.
>> This has already been skipped for MySQL backend.
>> 
>> Do we know if someone is working on trying to fix this or can we skip this
>> for now for Postgres backend as well?
>> 
>> Best,
>> *Verdan Mahmood*
> 


Re: Flaky test case: test_mark_success_no_kill

Posted by Taylor Edmiston <te...@gmail.com>.
Good catch.

I just made a branch to skip this test on PostgreSQL.  Working on an issue and PR now.

https://github.com/apache/incubator-airflow/compare/master...astronomerio:test_mark_success_no_kill-postgresql <https://github.com/apache/incubator-airflow/compare/master...astronomerio:test_mark_success_no_kill-postgresql>

Taylor Edmiston
Blog <https://blog.tedmiston.com/> | CV <https://stackoverflow.com/cv/taylor> | LinkedIn <https://www.linkedin.com/in/tedmiston/> | AngelList <https://angel.co/taylor> | Stack Overflow <https://stackoverflow.com/users/149428/taylor-edmiston>


> On Jul 25, 2018, at 8:06 AM, Verdan Mahmood <ve...@gmail.com> wrote:
> 
> Hi,
> 
> The test "test_mark_success_no_kill" is flaky and fails most of the time
> when running with Python 3.5 and Postgres backend, causing builds to be
> failed.
> This has already been skipped for MySQL backend.
> 
> Do we know if someone is working on trying to fix this or can we skip this
> for now for Postgres backend as well?
> 
> Best,
> *Verdan Mahmood*