You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cassandra.apache.org by Blake Eggleston <be...@apple.com.INVALID> on 2019/07/01 20:32:39 UTC
Time for a new 3.0/3.11 release?
Hi dev@,
Any objections to doing a new 3.0 and 3.11 release? Both branches have accumulated a decent number of changes since their last release, the highlights being improved merkle tree footprint, a gossip race, and a handful of 2.1 -> 3.x upgrade bugs.
Thanks,
Blake
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cassandra.apache.org
For additional commands, e-mail: dev-help@cassandra.apache.org
Re: Time for a new 3.0/3.11 release?
Posted by Sam Tunnicliffe <sa...@beobal.com>.
It would also be good to include CASSANDRA-15193 (which I only just created, sorry), as the counterpart to CASSANDRA-15176. I have a patch for this mostly done and will post it in the next day or two.
> On 2 Jul 2019, at 07:13, Mick Semb Wever <mc...@apache.org> wrote:
>
>> It would be nice to have time to get CASSANDRA-14812 in
>
> Yes.
>
> I will try and wrap up my review of 14812 today. Another pair of eyes is always welcome, especially anyone with experience on the various StoppingTransformation usages.
>
> regards,
> Mick
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@cassandra.apache.org
> For additional commands, e-mail: dev-help@cassandra.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cassandra.apache.org
For additional commands, e-mail: dev-help@cassandra.apache.org
Re: Time for a new 3.0/3.11 release?
Posted by ajs6f <aj...@apache.org>.
Thanks very much for this information-- it is indeed very helpful. This statement:
> Indeed, the trunk branch has been frozen for new feature inclusion for quite some time, and there have been some limited discussions on how long this might be. "When it's done" is basically the current answer, while the existing in-flight, approved feature jiras are still in progress or under review.
is the most precise and concise description I've been able to get of the situation. I'll leave the ticket open since other people were interested in the feature but leave it to them to pursue, or I can certainly close the ticket if that seems better.
> This is an example of a possible problem with a long-frozen trunk branch - new things may need to sit in limbo for a while, until cassandra-4.0 is branched and there is an opportunity to commit new features to trunk again.
Speaking only for myself, the problem is not exactly a long-frozen trunk branch-- the problem is that there is no date (not even a prospective date) at all for the end of that freeze and so I cannot prepare for it. For the task I wanted to solve with 15005 I will take a different approach, because I cannot plan to use Cassandra in my environment if I cannot assume anything at all about when releases will be made.
Thanks!
ajs6f
> On Jul 8, 2019, at 12:37 PM, Michael Shuler <mi...@pbandjelly.org> wrote:
>
> On 7/3/19 1:44 PM, ajs6f@apache.org wrote:
>> In fact there is a branch for it noted in the ticket, from which a
>> patch could be cut instantly, but there doesn't seem to be any point
>> to doing that until the feature freeze is over. Is there any sense of
>> timing on that? I've seen a few discussions about release process for
>> 4.x on this list, but I haven't been able to get a sense of how long
>> it might be.
>
> I see a couple different links to a couple different branches and a github compare with conflicts in comments in CASSANDRA-15005. I see no PR link, and the project doesn't use PRs in practice. There is no patch attached to the jira. I also see a link to an open related jira and discussion around that. I don't know the details of the actual feature/improvement, but the discussion appears (to me) to still be a discussion. It does not look (to me) like a finalized patch with completed CI links, etc. ready for someone to review. Regardless, it does not appear (to me) to be appropriate for 3.11.x.
>
> The cassandra-3.11 branch is in maintenance mode, which means no new features. Improvements require discussion and consensus for inclusion in maintenance branches, in order to keep breaking changes to a minimum. New features should target the trunk branch (4.0), unless there is a previously obtained consensus to include a particular improvement/feature in an earlier branch. Indeed, the trunk branch has been frozen for new feature inclusion for quite some time, and there have been some limited discussions on how long this might be. "When it's done" is basically the current answer, while the existing in-flight, approved feature jiras are still in progress or under review.
>
> With trunk frozen, this feature may need to simply wait. This is an example of a possible problem with a long-frozen trunk branch - new things may need to sit in limbo for a while, until cassandra-4.0 is branched and there is an opportunity to commit new features to trunk again.
>
> I hope that helps! Some of the above is definitely my understanding and some subjective observation of that specific jira.
>
> (An update on the current state of in-progress/review statuses for 4.0 jiras from the folks working on them would be awesome! hint hint.)
>
> Kind regards,
> Michael
>
>> On Wed, Jul 3, 2019, 1:28 AM Mick Semb Wever <mck@apache.org
>> <ma...@apache.org>> wrote:
>>> Is there any chance to get CASSANDRA-15005 (ready, with PR) into a 3.11.5 release?
>> I doubt it Soroka. It's not a bug and there's no patch for it, so I'd
>> see no reason why Michael would wait for this when he generously
>> finds time to cut a release.
>> Maybe the author and reviewer decides to push it to both 3.11.x and
>> 4.0, but that's irrelevant to this thread.
>> regards, Mick
>> ---------------------------------------------------------------------
>>
> To unsubscribe, e-mail: dev-unsubscribe@cassandra.apache.org <ma...@cassandra.apache.org>
>> For additional commands, e-mail: dev-help@cassandra.apache.org
>> <ma...@cassandra.apache.org>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@cassandra.apache.org
> For additional commands, e-mail: dev-help@cassandra.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cassandra.apache.org
For additional commands, e-mail: dev-help@cassandra.apache.org
Re: Time for a new 3.0/3.11 release?
Posted by Michael Shuler <mi...@pbandjelly.org>.
On 7/3/19 1:44 PM, ajs6f@apache.org wrote:
> In fact there is a branch for it noted in the ticket, from which a
> patch could be cut instantly, but there doesn't seem to be any point
> to doing that until the feature freeze is over. Is there any sense of
> timing on that? I've seen a few discussions about release process for
> 4.x on this list, but I haven't been able to get a sense of how long
> it might be.
I see a couple different links to a couple different branches and a
github compare with conflicts in comments in CASSANDRA-15005. I see no
PR link, and the project doesn't use PRs in practice. There is no patch
attached to the jira. I also see a link to an open related jira and
discussion around that. I don't know the details of the actual
feature/improvement, but the discussion appears (to me) to still be a
discussion. It does not look (to me) like a finalized patch with
completed CI links, etc. ready for someone to review. Regardless, it
does not appear (to me) to be appropriate for 3.11.x.
The cassandra-3.11 branch is in maintenance mode, which means no new
features. Improvements require discussion and consensus for inclusion in
maintenance branches, in order to keep breaking changes to a minimum.
New features should target the trunk branch (4.0), unless there is a
previously obtained consensus to include a particular
improvement/feature in an earlier branch. Indeed, the trunk branch has
been frozen for new feature inclusion for quite some time, and there
have been some limited discussions on how long this might be. "When it's
done" is basically the current answer, while the existing in-flight,
approved feature jiras are still in progress or under review.
With trunk frozen, this feature may need to simply wait. This is an
example of a possible problem with a long-frozen trunk branch - new
things may need to sit in limbo for a while, until cassandra-4.0 is
branched and there is an opportunity to commit new features to trunk again.
I hope that helps! Some of the above is definitely my understanding and
some subjective observation of that specific jira.
(An update on the current state of in-progress/review statuses for 4.0
jiras from the folks working on them would be awesome! hint hint.)
Kind regards,
Michael
>
> On Wed, Jul 3, 2019, 1:28 AM Mick Semb Wever <mck@apache.org
> <ma...@apache.org>> wrote:
>
>
>> Is there any chance to get CASSANDRA-15005 (ready, with PR) into a
>> 3.11.5 release?
>
>
> I doubt it Soroka. It's not a bug and there's no patch for it, so I'd
> see no reason why Michael would wait for this when he generously
> finds time to cut a release.
>
> Maybe the author and reviewer decides to push it to both 3.11.x and
> 4.0, but that's irrelevant to this thread.
>
> regards, Mick
>
> ---------------------------------------------------------------------
>
>
To unsubscribe, e-mail: dev-unsubscribe@cassandra.apache.org
<ma...@cassandra.apache.org>
> For additional commands, e-mail: dev-help@cassandra.apache.org
> <ma...@cassandra.apache.org>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cassandra.apache.org
For additional commands, e-mail: dev-help@cassandra.apache.org
Re: Time for a new 3.0/3.11 release?
Posted by aj...@apache.org.
In fact there is a branch for it noted in the ticket, from which a patch could be cut instantly, but there doesn't seem to be any point to doing that until the feature freeze is over. Is there any sense of timing on that? I've seen a few discussions about release process for 4.x on this list, but I haven't been able to get a sense of how long it might be.
ajs6f
On Wed, Jul 3, 2019, 1:28 AM Mick Semb Wever <mck@apache.org <ma...@apache.org>> wrote:
> Is there any chance to get CASSANDRA-15005 (ready, with PR) into a
> 3.11.5 release?
I doubt it Soroka. It's not a bug and there's no patch for it, so I'd see no reason why Michael would wait for this when he generously finds time to cut a release.
Maybe the author and reviewer decides to push it to both 3.11.x and 4.0, but that's irrelevant to this thread.
regards,
Mick
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cassandra.apache.org <ma...@cassandra.apache.org>
For additional commands, e-mail: dev-help@cassandra.apache.org <ma...@cassandra.apache.org>
Re: Request for review - 2 jiras for 3.0/3.11
Posted by Dinesh Joshi <dj...@apache.org>.
I can help review these Jiras. However, they are touching the gossip subsystem and would recommend someone more familiar with that part of the code to do a 2nd pass before we commit it.
Thanks,
Dinesh
> On Jul 8, 2019, at 10:53 AM, Michael Shuler <mi...@pbandjelly.org> wrote:
>
> Resending as a new req-for-review thread for visibility, since they look important to my untrained eye:
>
> https://issues.apache.org/jira/browse/CASSANDRA-15097
> https://issues.apache.org/jira/browse/CASSANDRA-15098
>
> Michael
>
> -------- Forwarded Message --------
> Subject: Re: Time for a new 3.0/3.11 release?
> Date: Wed, 3 Jul 2019 10:38:38 -0700
> From: Jay Zhuang <jz...@apache.org>
> Reply-To: dev@cassandra.apache.org
> To: dev@cassandra.apache.org
>
> I'd like to raise some attention for the following 2 tickets, they're
> patch-ready and deployed on all our production clusters:
> * CASSANDRA-15098: "Endpoints no longer owning tokens are not removed for
> vnode"
> For vNode cluster, the replaced node may not be removed from gossiper
> (and system.peers, every time a node restart, they will be re-populated
> into gossiper from system.peers). The patch is pretty small and
> straightforward.
> * CASSANDRA-15097: "Avoid updating unchanged gossip state"
> I think this is a bug because it's not only causing large pending gossip
> tasks, it's also causing long token-metadata update lock for large vNode
> cluster.
>
> Here is another improvement we made for vNode to avoid gossip block during
> removeNode: CASSANDRA-15141. But I think it can wait until 4.x. It mostly
> causes problem for 1000+ vNode clusters.
>
> Thanks,
> Jay
>
> On Tue, Jul 2, 2019 at 10:28 PM Mick Semb Wever <mc...@apache.org> wrote:
>
>>
>>
>> > Is there any chance to get CASSANDRA-15005 (ready, with PR) into a
>> > 3.11.5 release?
>>
>>
>> I doubt it Soroka. It's not a bug and there's no patch for it, so I'd see
>> no reason why Michael would wait for this when he generously finds time to
>> cut a release.
>>
>> Maybe the author and reviewer decides to push it to both 3.11.x and 4.0,
>> but that's irrelevant to this thread.
>>
>> regards,
>> Mick
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@cassandra.apache.org
>> For additional commands, e-mail: dev-help@cassandra.apache.org
>>
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@cassandra.apache.org
> For additional commands, e-mail: dev-help@cassandra.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cassandra.apache.org
For additional commands, e-mail: dev-help@cassandra.apache.org
Request for review - 2 jiras for 3.0/3.11
Posted by Michael Shuler <mi...@pbandjelly.org>.
Resending as a new req-for-review thread for visibility, since they look
important to my untrained eye:
https://issues.apache.org/jira/browse/CASSANDRA-15097
https://issues.apache.org/jira/browse/CASSANDRA-15098
Michael
-------- Forwarded Message --------
Subject: Re: Time for a new 3.0/3.11 release?
Date: Wed, 3 Jul 2019 10:38:38 -0700
From: Jay Zhuang <jz...@apache.org>
Reply-To: dev@cassandra.apache.org
To: dev@cassandra.apache.org
I'd like to raise some attention for the following 2 tickets, they're
patch-ready and deployed on all our production clusters:
* CASSANDRA-15098: "Endpoints no longer owning tokens are not removed for
vnode"
For vNode cluster, the replaced node may not be removed from gossiper
(and system.peers, every time a node restart, they will be re-populated
into gossiper from system.peers). The patch is pretty small and
straightforward.
* CASSANDRA-15097: "Avoid updating unchanged gossip state"
I think this is a bug because it's not only causing large pending gossip
tasks, it's also causing long token-metadata update lock for large vNode
cluster.
Here is another improvement we made for vNode to avoid gossip block during
removeNode: CASSANDRA-15141. But I think it can wait until 4.x. It mostly
causes problem for 1000+ vNode clusters.
Thanks,
Jay
On Tue, Jul 2, 2019 at 10:28 PM Mick Semb Wever <mc...@apache.org> wrote:
>
>
> > Is there any chance to get CASSANDRA-15005 (ready, with PR) into a
> > 3.11.5 release?
>
>
> I doubt it Soroka. It's not a bug and there's no patch for it, so I'd see
> no reason why Michael would wait for this when he generously finds time to
> cut a release.
>
> Maybe the author and reviewer decides to push it to both 3.11.x and 4.0,
> but that's irrelevant to this thread.
>
> regards,
> Mick
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@cassandra.apache.org
> For additional commands, e-mail: dev-help@cassandra.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cassandra.apache.org
For additional commands, e-mail: dev-help@cassandra.apache.org
Re: Time for a new 3.0/3.11 release?
Posted by Jay Zhuang <jz...@apache.org>.
I'd like to raise some attention for the following 2 tickets, they're
patch-ready and deployed on all our production clusters:
* CASSANDRA-15098: "Endpoints no longer owning tokens are not removed for
vnode"
For vNode cluster, the replaced node may not be removed from gossiper
(and system.peers, every time a node restart, they will be re-populated
into gossiper from system.peers). The patch is pretty small and
straightforward.
* CASSANDRA-15097: "Avoid updating unchanged gossip state"
I think this is a bug because it's not only causing large pending gossip
tasks, it's also causing long token-metadata update lock for large vNode
cluster.
Here is another improvement we made for vNode to avoid gossip block during
removeNode: CASSANDRA-15141. But I think it can wait until 4.x. It mostly
causes problem for 1000+ vNode clusters.
Thanks,
Jay
On Tue, Jul 2, 2019 at 10:28 PM Mick Semb Wever <mc...@apache.org> wrote:
>
>
> > Is there any chance to get CASSANDRA-15005 (ready, with PR) into a
> > 3.11.5 release?
>
>
> I doubt it Soroka. It's not a bug and there's no patch for it, so I'd see
> no reason why Michael would wait for this when he generously finds time to
> cut a release.
>
> Maybe the author and reviewer decides to push it to both 3.11.x and 4.0,
> but that's irrelevant to this thread.
>
> regards,
> Mick
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@cassandra.apache.org
> For additional commands, e-mail: dev-help@cassandra.apache.org
>
>
Re: Time for a new 3.0/3.11 release?
Posted by Mick Semb Wever <mc...@apache.org>.
> Is there any chance to get CASSANDRA-15005 (ready, with PR) into a
> 3.11.5 release?
I doubt it Soroka. It's not a bug and there's no patch for it, so I'd see no reason why Michael would wait for this when he generously finds time to cut a release.
Maybe the author and reviewer decides to push it to both 3.11.x and 4.0, but that's irrelevant to this thread.
regards,
Mick
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cassandra.apache.org
For additional commands, e-mail: dev-help@cassandra.apache.org
Re: Time for a new 3.0/3.11 release?
Posted by ajs6f <aj...@apache.org>.
Is there any chance to get CASSANDRA-15005 (ready, with PR) into a 3.11.5 release? I understand that there is a feature freeze, but I do see some small tickets (eg. CASSANDRA-15090) that would seem to have been merged for release, and I think 15005 is quite small, too. I'm happy to do whatever I can to help this happen. The current branch for 15005 is for 4.x, but it was originally written by Jon Meredith for 3.x and I could easily move it back to that line.
Thanks!
ajs6f
> On Jul 2, 2019, at 6:23 AM, Mick Semb Wever <mc...@apache.org> wrote:
>
>
>> I will try and wrap up my review of 14812 today.
>
>
> CASSANDRA-14812 has been committed.
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@cassandra.apache.org
> For additional commands, e-mail: dev-help@cassandra.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cassandra.apache.org
For additional commands, e-mail: dev-help@cassandra.apache.org
Re: Time for a new 3.0/3.11 release?
Posted by Mick Semb Wever <mc...@apache.org>.
> I will try and wrap up my review of 14812 today.
CASSANDRA-14812 has been committed.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cassandra.apache.org
For additional commands, e-mail: dev-help@cassandra.apache.org
Re: Time for a new 3.0/3.11 release?
Posted by Mick Semb Wever <mc...@apache.org>.
> It would be nice to have time to get CASSANDRA-14812 in
Yes.
I will try and wrap up my review of 14812 today. Another pair of eyes is always welcome, especially anyone with experience on the various StoppingTransformation usages.
regards,
Mick
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cassandra.apache.org
For additional commands, e-mail: dev-help@cassandra.apache.org
Re: Time for a new 3.0/3.11 release?
Posted by Benedict Elliott Smith <be...@apache.org>.
It would be nice to have time to get CASSANDRA-14812 in, as it was also (consciously) missed from the last release, and struggled to find a reviewer since. Mick kindly found time to take a look while I was away. It’s a bit rough to force affected users to wait another lengthy release cycle for this fix, simply because nobody active in the community really cares too much about thrift.
> On 2 Jul 2019, at 00:16, Michael Shuler <mi...@pbandjelly.org> wrote:
>
> On 7/1/19 3:32 PM, Blake Eggleston wrote:
>> Any objections to doing a new 3.0 and 3.11 release? Both branches
>> have accumulated a decent number of changes since their last release,
>> the highlights being improved merkle tree footprint, a gossip race,
>> and a handful of 2.1 -> 3.x upgrade bugs.
>
> I was looking at these changelogs, recently, and time since last releases, when trying to fix the downloads page. Yep, it's time :)
>
> I am about to take some time off for the rest of this week, but can roll up some releases & start a vote on July 8th-ish, if there's no objections that pop up.
>
> --
> Kind regards,
> Michael
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@cassandra.apache.org
> For additional commands, e-mail: dev-help@cassandra.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cassandra.apache.org
For additional commands, e-mail: dev-help@cassandra.apache.org
Re: Time for a new 3.0/3.11 release?
Posted by Michael Shuler <mi...@pbandjelly.org>.
On 7/1/19 3:32 PM, Blake Eggleston wrote:
> Any objections to doing a new 3.0 and 3.11 release? Both branches
> have accumulated a decent number of changes since their last release,
> the highlights being improved merkle tree footprint, a gossip race,
> and a handful of 2.1 -> 3.x upgrade bugs.
I was looking at these changelogs, recently, and time since last
releases, when trying to fix the downloads page. Yep, it's time :)
I am about to take some time off for the rest of this week, but can roll
up some releases & start a vote on July 8th-ish, if there's no
objections that pop up.
--
Kind regards,
Michael
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cassandra.apache.org
For additional commands, e-mail: dev-help@cassandra.apache.org