[GitHub] tysonnorris commented on a change in pull request #4186: Track activation counts in ContainerPool (not ContainerProxy)

[GitBox <gi...@apache.org>]

tysonnorris commented on a change in pull request #4186: Track activation counts in ContainerPool (not ContainerProxy)
URL: https://github.com/apache/incubator-openwhisk/pull/4186#discussion_r250066438
 
 

 ##########
 File path: core/invoker/src/main/scala/org/apache/openwhisk/core/containerpool/ContainerPool.scala
 ##########
 @@ -112,7 +112,17 @@ class ContainerPool(childFactory: ActorRefFactory => ActorRef,
             // Schedule a job to a warm container
             ContainerPool
               .schedule(r.action, r.msg.user.namespace.name, freePool)
-              .map(container => (container, "warm"))
+              .map { container =>
+                val warmState = container._2 match {
 
 Review comment:
   This cannot be done exactly, since the logged string indicating state does not map directly to specific `ContainerData` types; this is one of several problems where `ContainerData` is reused as a) indicator of container status in `ContainerPool` and b) state management within `ContainerProxy`. There is some overlap, but there are a few unique concerns for each so there is some mismatch when used in one or the other. I updated ContainerData to have `initingState`, but it cannot be used in all cases.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services