You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/12/02 11:27:18 UTC
[GitHub] [spark] LuciferYang opened a new pull request #30569: [SPARK-33631][DOC][TEST] Clean up spark.core.connection.ack.wait.timeout from configuration.md
LuciferYang opened a new pull request #30569:
URL: https://github.com/apache/spark/pull/30569
### What changes were proposed in this pull request?
SPARK-9767 remove `ConnectionManager` and related classes, the configuration item `spark.core.connection.ack.wait.timeout` previously used by `ConnectionManager` is no longer used by other Spark code, but it still exists in the `configuration.md`, so this pr cleans up the configuration item from `configuration.md`.
### Why are the changes needed?
Clean up useless configuration from `configuration.md`.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Pass the Jenkins or GitHub Action
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #30569: [SPARK-33631][DOCS][TEST] Clean up spark.core.connection.ack.wait.timeout from configuration.md
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on pull request #30569:
URL: https://github.com/apache/spark/pull/30569#issuecomment-737636133
Thank you @srowen and @dongjoon-hyun ~
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30569: [SPARK-33631][DOCS][TEST] Clean up spark.core.connection.ack.wait.timeout from configuration.md
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30569:
URL: https://github.com/apache/spark/pull/30569#issuecomment-737438441
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30569: [SPARK-33631][DOCS][TEST] Clean up spark.core.connection.ack.wait.timeout from configuration.md
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30569:
URL: https://github.com/apache/spark/pull/30569#issuecomment-737405109
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30569: [SPARK-33631][DOCS][TEST] Clean up spark.core.connection.ack.wait.timeout from configuration.md
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30569:
URL: https://github.com/apache/spark/pull/30569#issuecomment-737346489
**[Test build #132064 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132064/testReport)** for PR 30569 at commit [`1f537c9`](https://github.com/apache/spark/commit/1f537c9045977b1b02a15779bbee63f6434dca3c).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30569: [SPARK-33631][DOCS][TEST] Clean up spark.core.connection.ack.wait.timeout from configuration.md
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30569:
URL: https://github.com/apache/spark/pull/30569#issuecomment-737346489
**[Test build #132064 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132064/testReport)** for PR 30569 at commit [`1f537c9`](https://github.com/apache/spark/commit/1f537c9045977b1b02a15779bbee63f6434dca3c).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30569: [SPARK-33631][DOCS][TEST] Clean up spark.core.connection.ack.wait.timeout from configuration.md
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30569:
URL: https://github.com/apache/spark/pull/30569#issuecomment-737222201
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30569: [SPARK-33631][DOCS][TEST] Clean up spark.core.connection.ack.wait.timeout from configuration.md
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30569:
URL: https://github.com/apache/spark/pull/30569#issuecomment-737417421
**[Test build #132064 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132064/testReport)** for PR 30569 at commit [`1f537c9`](https://github.com/apache/spark/commit/1f537c9045977b1b02a15779bbee63f6434dca3c).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30569: [SPARK-33631][DOCS][TEST] Clean up spark.core.connection.ack.wait.timeout from configuration.md
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30569:
URL: https://github.com/apache/spark/pull/30569#issuecomment-737226845
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30569: [SPARK-33631][DOCS][TEST] Clean up spark.core.connection.ack.wait.timeout from configuration.md
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30569:
URL: https://github.com/apache/spark/pull/30569#issuecomment-737226845
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30569: [SPARK-33631][DOCS][TEST] Clean up spark.core.connection.ack.wait.timeout from configuration.md
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30569:
URL: https://github.com/apache/spark/pull/30569#issuecomment-737226323
**[Test build #132044 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132044/testReport)** for PR 30569 at commit [`1f537c9`](https://github.com/apache/spark/commit/1f537c9045977b1b02a15779bbee63f6434dca3c).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30569: [SPARK-33631][DOCS][TEST] Clean up spark.core.connection.ack.wait.timeout from configuration.md
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30569:
URL: https://github.com/apache/spark/pull/30569#issuecomment-737405109
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #30569: [SPARK-33631][DOCS][TEST] Clean up spark.core.connection.ack.wait.timeout from configuration.md
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #30569:
URL: https://github.com/apache/spark/pull/30569
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30569: [SPARK-33631][DOCS][TEST] Clean up spark.core.connection.ack.wait.timeout from configuration.md
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30569:
URL: https://github.com/apache/spark/pull/30569#issuecomment-737171951
**[Test build #132044 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132044/testReport)** for PR 30569 at commit [`1f537c9`](https://github.com/apache/spark/commit/1f537c9045977b1b02a15779bbee63f6434dca3c).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30569: [SPARK-33631][DOCS][TEST] Clean up spark.core.connection.ack.wait.timeout from configuration.md
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30569:
URL: https://github.com/apache/spark/pull/30569#issuecomment-737222179
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30569: [SPARK-33631][DOCS][TEST] Clean up spark.core.connection.ack.wait.timeout from configuration.md
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30569:
URL: https://github.com/apache/spark/pull/30569#issuecomment-737171951
**[Test build #132044 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132044/testReport)** for PR 30569 at commit [`1f537c9`](https://github.com/apache/spark/commit/1f537c9045977b1b02a15779bbee63f6434dca3c).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #30569: [SPARK-33631][DOCS][TEST] Clean up spark.core.connection.ack.wait.timeout from configuration.md
Posted by GitBox <gi...@apache.org>.
srowen commented on pull request #30569:
URL: https://github.com/apache/spark/pull/30569#issuecomment-737343562
Jenkins retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30569: [SPARK-33631][DOCS][TEST] Clean up spark.core.connection.ack.wait.timeout from configuration.md
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30569:
URL: https://github.com/apache/spark/pull/30569#issuecomment-737438441
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org