You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by GitBox <gi...@apache.org> on 2019/01/17 01:50:57 UTC
[GitHub] zjffdu commented on a change in pull request #3281: [ZEPPELIN-3943]
- Add button "stop notebook execution"
zjffdu commented on a change in pull request #3281: [ZEPPELIN-3943] - Add button "stop notebook execution"
URL: https://github.com/apache/zeppelin/pull/3281#discussion_r248515673
##########
File path: zeppelin-server/src/main/java/org/apache/zeppelin/service/NotebookService.java
##########
@@ -340,27 +344,67 @@ public void runAllParagraphs(String noteId,
return;
}
- note.setRunning(true);
- try {
- for (Map<String, Object> raw : paragraphs) {
- String paragraphId = (String) raw.get("id");
- if (paragraphId == null) {
- continue;
- }
- String text = (String) raw.get("paragraph");
- String title = (String) raw.get("title");
- Map<String, Object> params = (Map<String, Object>) raw.get("params");
- Map<String, Object> config = (Map<String, Object>) raw.get("config");
-
- if (!runParagraph(noteId, paragraphId, title, text, params, config, false, true,
- context, callback)) {
- // stop execution when one paragraph fails.
- break;
+ synchronized (note) {
+ if (note.isRunning()) {
+ LOGGER.warn("Can't run note because it already is running");
+ return;
+ }
+ note.setRunning(true);
+ }
+
+ noteExecutor.execute(() -> {
+ try {
+ for (Map<String, Object> raw : paragraphs) {
+ String paragraphId = (String) raw.get("id");
+ if (paragraphId == null) {
+ continue;
+ }
+ String text = (String) raw.get("paragraph");
+ String title = (String) raw.get("title");
+ Map<String, Object> params = (Map<String, Object>) raw.get("params");
+ Map<String, Object> config = (Map<String, Object>) raw.get("config");
+
+ if (note.isExecutionAborted() || !runParagraph(noteId, paragraphId, title, text,
+ params, config, false, true, context, callback)) {
+ // stop execution when one paragraph fails.
+ break;
Review comment:
I think this is duplicated with Note#runAll
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services