You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by "lowka (via GitHub)" <gi...@apache.org> on 2023/06/22 12:22:17 UTC
[GitHub] [ignite-3] lowka commented on a diff in pull request #2199: [WIP] IGNITE-19726: Sql. Migrate index operations to ScannableTable.
lowka commented on code in PR #2199:
URL: https://github.com/apache/ignite-3/pull/2199#discussion_r1238450494
##########
modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/exec/rel/IndexScanNodeTest.java:
##########
@@ -0,0 +1,288 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.sql.engine.exec.rel;
+
+import static org.junit.jupiter.api.Assertions.assertArrayEquals;
+import static org.junit.jupiter.api.Assertions.assertEquals;
+
+import java.util.ArrayList;
+import java.util.BitSet;
+import java.util.Comparator;
+import java.util.List;
+import java.util.Map;
+import java.util.Objects;
+import java.util.TreeSet;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.concurrent.Flow.Publisher;
+import java.util.concurrent.Flow.Subscriber;
+import java.util.concurrent.Flow.Subscription;
+import java.util.stream.Collectors;
+import org.apache.calcite.rel.type.RelDataType;
+import org.apache.calcite.rel.type.RelDataTypeFactory;
+import org.apache.calcite.rel.type.RelDataTypeFactory.Builder;
+import org.apache.calcite.sql.type.SqlTypeName;
+import org.apache.ignite.internal.index.ColumnCollation;
+import org.apache.ignite.internal.index.HashIndex;
+import org.apache.ignite.internal.index.IndexDescriptor;
+import org.apache.ignite.internal.index.SortedIndexDescriptor;
+import org.apache.ignite.internal.index.SortedIndexImpl;
+import org.apache.ignite.internal.sql.engine.exec.ExecutionContext;
+import org.apache.ignite.internal.sql.engine.exec.RowHandler.RowFactory;
+import org.apache.ignite.internal.sql.engine.exec.ScannableTable;
+import org.apache.ignite.internal.sql.engine.exec.exp.RangeCondition;
+import org.apache.ignite.internal.sql.engine.metadata.PartitionWithTerm;
+import org.apache.ignite.internal.sql.engine.planner.AbstractPlannerTest.TestTableDescriptor;
+import org.apache.ignite.internal.sql.engine.schema.IgniteIndex;
+import org.apache.ignite.internal.sql.engine.schema.TableDescriptor;
+import org.apache.ignite.internal.sql.engine.trait.IgniteDistributions;
+import org.apache.ignite.internal.sql.engine.util.Commons;
+import org.apache.ignite.internal.table.InternalTable;
+import org.jetbrains.annotations.Nullable;
+import org.junit.jupiter.api.Test;
+import org.mockito.Mockito;
+
+/**
+ * Test {@link IndexScanNode} execution.
+ */
+public class IndexScanNodeTest extends AbstractExecutionTest {
+
+ /**
+ * Sorted index scan execution.
+ */
+ @Test
+ @SuppressWarnings({"unchecked", "rawtypes"})
+ public void testSortedIndex() {
+ IgniteIndex index = newSortedIndex();
+
+ TestScannableTable<Object[]> scannableTable = new TestScannableTable<>();
+ scannableTable.setPartitionData(0, new Object[]{4}, new Object[]{5});
+ scannableTable.setPartitionData(2, new Object[]{1}, new Object[]{2});
+
+ Comparator<Object[]> cmp = (a, b) -> {
+ Comparable o1 = (Comparable<?>) a[0];
+ Comparable o2 = (Comparable<?>) b[0];
+ return o1.compareTo(o2);
+ };
+
+ Tester tester = new Tester();
+
+ IndexScanNode<Object[]> node = tester.createSortedIndex(index, scannableTable, cmp);
+ List<Object[]> result = tester.execute(node);
+
+ tester.expectResult(result, new Object[]{1}, new Object[]{2}, new Object[]{4}, new Object[]{5});
+ }
+
+ /**
+ * Hash index lookup execution.
+ */
+ @Test
+ public void testHashIndex() {
+ IgniteIndex index = newHashIndex();
+
+ TestScannableTable<Object[]> scannableTable = new TestScannableTable<>();
+ scannableTable.setPartitionData(0, new Object[]{2}, new Object[]{1});
+ scannableTable.setPartitionData(2, new Object[]{0});
+
+ Tester tester = new Tester();
+
+ IndexScanNode<Object[]> node = tester.createHashIndex(index, scannableTable);
+ List<Object[]> result = tester.execute(node);
+
+ tester.expectResult(result, new Object[]{2}, new Object[]{1}, new Object[]{0});
+ }
+
+ private static IgniteIndex newHashIndex() {
+ IndexDescriptor descriptor = new IndexDescriptor("IDX", List.of("C1"));
+ HashIndex index = new HashIndex(1, Mockito.mock(InternalTable.class), descriptor);
+
+ return new IgniteIndex(index);
+ }
+
+ private static IgniteIndex newSortedIndex() {
+ List<String> columnNames = List.of("C1");
+ List<ColumnCollation> columnCollations = List.of(ColumnCollation.ASC_NULLS_LAST);
+ SortedIndexDescriptor descriptor = new SortedIndexDescriptor("IDX", columnNames, columnCollations);
+ SortedIndexImpl index = new SortedIndexImpl(1, Mockito.mock(InternalTable.class), descriptor);
+
+ return new IgniteIndex(index);
+ }
+
+ private class Tester {
+
+ private final ExecutionContext<Object[]> ctx;
+
+ Tester() {
+ this.ctx = executionContext();
+ }
+
+ IndexScanNode<Object[]> createSortedIndex(IgniteIndex index, TestScannableTable<?> scannableTable, Comparator<Object[]> cmp) {
+ return createIndexNode(ctx, index, scannableTable, cmp);
+ }
+
+ IndexScanNode<Object[]> createHashIndex(IgniteIndex index, TestScannableTable<?> scannableTable) {
+ return createIndexNode(ctx, index, scannableTable, null);
+ }
+
+ List<Object[]> execute(IndexScanNode<Object[]> indexNode) {
+ RootNode<Object[]> root = new RootNode<>(ctx);
+
+ root.register(indexNode);
+
+ List<Object[]> actual = new ArrayList<>();
+ while (root.hasNext()) {
+ Object[] row = root.next();
+ actual.add(row);
+ }
+
+ root.close();
+
+ return actual;
+ }
+
+ void expectResult(List<Object[]> actual, Object[]... expected) {
Review Comment:
Fixed.
##########
modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/exec/rel/IndexScanNodeTest.java:
##########
@@ -0,0 +1,288 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.sql.engine.exec.rel;
+
+import static org.junit.jupiter.api.Assertions.assertArrayEquals;
+import static org.junit.jupiter.api.Assertions.assertEquals;
+
+import java.util.ArrayList;
+import java.util.BitSet;
+import java.util.Comparator;
+import java.util.List;
+import java.util.Map;
+import java.util.Objects;
+import java.util.TreeSet;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.concurrent.Flow.Publisher;
+import java.util.concurrent.Flow.Subscriber;
+import java.util.concurrent.Flow.Subscription;
+import java.util.stream.Collectors;
+import org.apache.calcite.rel.type.RelDataType;
+import org.apache.calcite.rel.type.RelDataTypeFactory;
+import org.apache.calcite.rel.type.RelDataTypeFactory.Builder;
+import org.apache.calcite.sql.type.SqlTypeName;
+import org.apache.ignite.internal.index.ColumnCollation;
+import org.apache.ignite.internal.index.HashIndex;
+import org.apache.ignite.internal.index.IndexDescriptor;
+import org.apache.ignite.internal.index.SortedIndexDescriptor;
+import org.apache.ignite.internal.index.SortedIndexImpl;
+import org.apache.ignite.internal.sql.engine.exec.ExecutionContext;
+import org.apache.ignite.internal.sql.engine.exec.RowHandler.RowFactory;
+import org.apache.ignite.internal.sql.engine.exec.ScannableTable;
+import org.apache.ignite.internal.sql.engine.exec.exp.RangeCondition;
+import org.apache.ignite.internal.sql.engine.metadata.PartitionWithTerm;
+import org.apache.ignite.internal.sql.engine.planner.AbstractPlannerTest.TestTableDescriptor;
+import org.apache.ignite.internal.sql.engine.schema.IgniteIndex;
+import org.apache.ignite.internal.sql.engine.schema.TableDescriptor;
+import org.apache.ignite.internal.sql.engine.trait.IgniteDistributions;
+import org.apache.ignite.internal.sql.engine.util.Commons;
+import org.apache.ignite.internal.table.InternalTable;
+import org.jetbrains.annotations.Nullable;
+import org.junit.jupiter.api.Test;
+import org.mockito.Mockito;
+
+/**
+ * Test {@link IndexScanNode} execution.
+ */
+public class IndexScanNodeTest extends AbstractExecutionTest {
+
+ /**
+ * Sorted index scan execution.
+ */
+ @Test
+ @SuppressWarnings({"unchecked", "rawtypes"})
+ public void testSortedIndex() {
+ IgniteIndex index = newSortedIndex();
+
+ TestScannableTable<Object[]> scannableTable = new TestScannableTable<>();
+ scannableTable.setPartitionData(0, new Object[]{4}, new Object[]{5});
+ scannableTable.setPartitionData(2, new Object[]{1}, new Object[]{2});
+
+ Comparator<Object[]> cmp = (a, b) -> {
+ Comparable o1 = (Comparable<?>) a[0];
+ Comparable o2 = (Comparable<?>) b[0];
+ return o1.compareTo(o2);
+ };
Review Comment:
Fixed.
##########
modules/table/src/main/java/org/apache/ignite/internal/utils/PrimaryReplica.java:
##########
@@ -57,4 +59,26 @@ public ClusterNode node() {
public long term() {
return term;
}
+
+ @Override
Review Comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org