You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/03/25 10:24:05 UTC
[GitHub] [spark] HyukjinKwon opened a new pull request #35973: [SPARK-38657][UI][SQL] Rename SQL to SQL & DataFrame, and Query to Execution in SQL UI page
HyukjinKwon opened a new pull request #35973:
URL: https://github.com/apache/spark/pull/35973
### What changes were proposed in this pull request?
This PR proposes to rename, in SQL UI page,
- `SQL` -> `SQL & DataFrame`
- `Query` -> `Execution`
### Why are the changes needed?
- DataFrame executions are also included in this page.
- Spark ML users will run DataFrame-based MLlib API, but they will have to check the "SQL" tab.
- Pandas API on Spark arguably has no link to SQL itself conceptually. It makes less sense to users of pandas API.
### Does this PR introduce _any_ user-facing change?
Yes. After this change, the rename proposed above will be applied as below:
### How was this patch tested?
Manually tested as above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #35973: [SPARK-38657][UI][SQL] Rename SQL to SQL & DataFrame, and Query to Execution in SQL UI page
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #35973:
URL: https://github.com/apache/spark/pull/35973#discussion_r835991771
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/ui/AllExecutionsPage.scala
##########
@@ -66,7 +66,7 @@ private[ui] class AllExecutionsPage(parent: SQLTab) extends WebUIPage("") with L
'aggregated-runningExecutions')">
<h4>
<span class="collapse-table-arrow arrow-open"></span>
- <a>Running Queries ({running.size})</a>
+ <a>Running Executions ({running.size})</a>
Review comment:
> DataFrame operations can be considered as queries.
That's actually in dev perspective .. to end users, it's not really queries .. e.g., to Scala/Java/Python DataFrame users, SS users, ML users or pandas API on Spark users
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #35973: [SPARK-38657][UI][SQL] Rename 'SQL' to 'SQL / DataFrame' in SQL UI page
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #35973:
URL: https://github.com/apache/spark/pull/35973#issuecomment-1082097640
+1, LGTM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AngersZhuuuu edited a comment on pull request #35973: [SPARK-38657][UI][SQL] Rename 'SQL' to 'SQL / DataFrame', and 'Query' to 'Execution' in SQL UI page
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu edited a comment on pull request #35973:
URL: https://github.com/apache/spark/pull/35973#issuecomment-1080306686
+1 LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] tgravescs commented on a change in pull request #35973: [SPARK-38657][UI][SQL] Rename 'SQL' to 'SQL / DataFrame', and 'Query' to 'Execution' in SQL UI page
Posted by GitBox <gi...@apache.org>.
tgravescs commented on a change in pull request #35973:
URL: https://github.com/apache/spark/pull/35973#discussion_r836727697
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/ui/AllExecutionsPage.scala
##########
@@ -66,7 +66,7 @@ private[ui] class AllExecutionsPage(parent: SQLTab) extends WebUIPage("") with L
'aggregated-runningExecutions')">
<h4>
<span class="collapse-table-arrow arrow-open"></span>
- <a>Running Queries ({running.size})</a>
+ <a>Running Executions ({running.size})</a>
Review comment:
I guess you could also say more explicitly SQL/Dataframe Queries.
Another option programmatic/declarative queries, although that seems kind of long.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #35973: [SPARK-38657][UI][SQL] Rename 'SQL' to 'SQL / DataFrame' in SQL UI page
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #35973:
URL: https://github.com/apache/spark/pull/35973#discussion_r837017796
##########
File path: core/src/main/resources/org/apache/spark/ui/static/webui.css
##########
@@ -88,12 +88,14 @@ a:not([href]):hover {
height: 50px;
padding: 10px 15px 10px;
line-height: 2;
+ white-space: nowrap;
}
.navbar .navbar-nav .nav-item.active .nav-link {
background-color: #e5e5e5;
box-shadow: inset 0 3px 8px rgba(0, 0, 0, 0.125);
color: #555555;
+ white-space: nowrap;
Review comment:
I piggyback one CSS change. Because `SQL / DataFrame` contains whitespace, we should make sure this line is separated (or wrapped) to the next line.
Before:
<img width="717" alt="Screen Shot 2022-03-29 at 12 16 03 PM" src="https://user-images.githubusercontent.com/6477701/160526045-7cffbb9f-37c4-4555-a9a0-447b9d538485.png">
After:
<img width="723" alt="Screen Shot 2022-03-29 at 12 16 06 PM" src="https://user-images.githubusercontent.com/6477701/160526054-f8657091-f30a-40a9-9232-08a3d69f6334.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on pull request #35973: [SPARK-38657][UI][SQL] Rename 'SQL' to 'SQL / DataFrame', and 'Query' to 'Execution' in SQL UI page
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on pull request #35973:
URL: https://github.com/apache/spark/pull/35973#issuecomment-1080306686
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #35973: [SPARK-38657][UI][SQL] Rename SQL to SQL & DataFrame, and Query to Execution in SQL UI page
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #35973:
URL: https://github.com/apache/spark/pull/35973#discussion_r835992226
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/ui/AllExecutionsPage.scala
##########
@@ -66,7 +66,7 @@ private[ui] class AllExecutionsPage(parent: SQLTab) extends WebUIPage("") with L
'aggregated-runningExecutions')">
<h4>
<span class="collapse-table-arrow arrow-open"></span>
- <a>Running Queries ({running.size})</a>
+ <a>Running Executions ({running.size})</a>
Review comment:
Will send an email to dev mailing list.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on a change in pull request #35973: [SPARK-38657][UI][SQL] Rename SQL to SQL & DataFrame, and Query to Execution in SQL UI page
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on a change in pull request #35973:
URL: https://github.com/apache/spark/pull/35973#discussion_r835201285
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/ui/ExecutionPage.scala
##########
@@ -159,7 +159,7 @@ class ExecutionPage(parent: SQLTab) extends WebUIPage("execution") with Logging
<span class="collapse-sql-properties collapse-table"
onClick="collapseTable('collapse-sql-properties', 'sql-properties')">
<span class="collapse-table-arrow arrow-closed"></span>
- <a>SQL Properties</a>
+ <a>SQL & DataFrame: Properties</a>
Review comment:
How about
```
SQL / Dataframe Properties
```
Or
```
Modified Properties
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #35973: [SPARK-38657][UI][SQL] Rename 'SQL' to 'SQL / DataFrame' in SQL UI page
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #35973:
URL: https://github.com/apache/spark/pull/35973
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on a change in pull request #35973: [SPARK-38657][UI][SQL] Rename SQL to SQL & DataFrame, and Query to Execution in SQL UI page
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on a change in pull request #35973:
URL: https://github.com/apache/spark/pull/35973#discussion_r835197301
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/ui/AllExecutionsPage.scala
##########
@@ -66,7 +66,7 @@ private[ui] class AllExecutionsPage(parent: SQLTab) extends WebUIPage("") with L
'aggregated-runningExecutions')">
<h4>
<span class="collapse-table-arrow arrow-open"></span>
- <a>Running Queries ({running.size})</a>
+ <a>Running Executions ({running.size})</a>
Review comment:
The word `Executions` looks odd to me.
How about just changing the tab name and leaving the word "Queries" as it is now? DataFrame operations can be considered as queries.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #35973: [SPARK-38657][UI][SQL] Rename 'SQL' to 'SQL / DataFrame' in SQL UI page
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #35973:
URL: https://github.com/apache/spark/pull/35973#issuecomment-1081348074
I kept the name "Query" as is for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #35973: [SPARK-38657][UI][SQL] Rename 'SQL' to 'SQL / DataFrame' in SQL UI page
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #35973:
URL: https://github.com/apache/spark/pull/35973#issuecomment-1081445721
Thanks!
Merged to master and branch-3.3.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] tgravescs commented on a change in pull request #35973: [SPARK-38657][UI][SQL] Rename 'SQL' to 'SQL / DataFrame', and 'Query' to 'Execution' in SQL UI page
Posted by GitBox <gi...@apache.org>.
tgravescs commented on a change in pull request #35973:
URL: https://github.com/apache/spark/pull/35973#discussion_r836511436
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/ui/AllExecutionsPage.scala
##########
@@ -66,7 +66,7 @@ private[ui] class AllExecutionsPage(parent: SQLTab) extends WebUIPage("") with L
'aggregated-runningExecutions')">
<h4>
<span class="collapse-table-arrow arrow-open"></span>
- <a>Running Queries ({running.size})</a>
+ <a>Running Executions ({running.size})</a>
Review comment:
I somewhat agree that executions sounds odd to me .
Execution 0, Execution 1, Execution 2 makes me wonder, is that executing the same command just multiple times or is it different operations.
I'm not sure I have a better idea then just leaving it Query though
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #35973: [SPARK-38657][UI][SQL] Rename 'SQL' to 'SQL / DataFrame' in SQL UI page
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #35973:
URL: https://github.com/apache/spark/pull/35973#discussion_r837017796
##########
File path: core/src/main/resources/org/apache/spark/ui/static/webui.css
##########
@@ -88,12 +88,14 @@ a:not([href]):hover {
height: 50px;
padding: 10px 15px 10px;
line-height: 2;
+ white-space: nowrap;
}
.navbar .navbar-nav .nav-item.active .nav-link {
background-color: #e5e5e5;
box-shadow: inset 0 3px 8px rgba(0, 0, 0, 0.125);
color: #555555;
+ white-space: nowrap;
Review comment:
I piggyback one CSS change. Because `SQL / DataFrame` contains whitespace, we should make sure this line is not separated (or wrapped) to the next line.
Before:
<img width="717" alt="Screen Shot 2022-03-29 at 12 16 03 PM" src="https://user-images.githubusercontent.com/6477701/160526045-7cffbb9f-37c4-4555-a9a0-447b9d538485.png">
After:
<img width="723" alt="Screen Shot 2022-03-29 at 12 16 06 PM" src="https://user-images.githubusercontent.com/6477701/160526054-f8657091-f30a-40a9-9232-08a3d69f6334.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #35973: [SPARK-38657][UI][SQL] Rename 'SQL' to 'SQL / DataFrame' in SQL UI page
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #35973:
URL: https://github.com/apache/spark/pull/35973#discussion_r837017796
##########
File path: core/src/main/resources/org/apache/spark/ui/static/webui.css
##########
@@ -88,12 +88,14 @@ a:not([href]):hover {
height: 50px;
padding: 10px 15px 10px;
line-height: 2;
+ white-space: nowrap;
}
.navbar .navbar-nav .nav-item.active .nav-link {
background-color: #e5e5e5;
box-shadow: inset 0 3px 8px rgba(0, 0, 0, 0.125);
color: #555555;
+ white-space: nowrap;
Review comment:
I piggyback one CSS change. Because `SQL / DataFrame` contains whitespace, we should make sure this line is separated (or wrapped) to the next line.
Before:
<img width="769" alt="Screen Shot 2022-03-29 at 12 14 16 PM" src="https://user-images.githubusercontent.com/6477701/160525974-73133494-4710-4988-8281-3642894a3cc9.png">
After:
<img width="787" alt="Screen Shot 2022-03-29 at 12 13 18 PM" src="https://user-images.githubusercontent.com/6477701/160525982-19118d58-d8a1-494c-924b-816a28b8c0f9.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #35973: [SPARK-38657][UI][SQL] Rename 'SQL' to 'SQL / DataFrame', and 'Query' to 'Execution' in SQL UI page
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #35973:
URL: https://github.com/apache/spark/pull/35973#discussion_r836939306
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/ui/AllExecutionsPage.scala
##########
@@ -66,7 +66,7 @@ private[ui] class AllExecutionsPage(parent: SQLTab) extends WebUIPage("") with L
'aggregated-runningExecutions')">
<h4>
<span class="collapse-table-arrow arrow-open"></span>
- <a>Running Queries ({running.size})</a>
+ <a>Running Executions ({running.size})</a>
Review comment:
Thanks for your suggestions. Let me think a bit more about it and your suggestions, and push some changes soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org