You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jdo-dev@db.apache.org by GitBox <gi...@apache.org> on 2022/02/02 21:30:50 UTC
[GitHub] [db-jdo] hboutemy opened a new pull request #36: upgrade Felix maven-bundle-plugin for Reproducible
hboutemy opened a new pull request #36:
URL: https://github.com/apache/db-jdo/pull/36
fix for bundle:manifest
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jdo-dev-unsubscribe@db.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [db-jdo] hboutemy commented on pull request #36: upgrade Felix maven-bundle-plugin for Reproducible
Posted by GitBox <gi...@apache.org>.
hboutemy commented on pull request #36:
URL: https://github.com/apache/db-jdo/pull/36#issuecomment-1043303823
> This will never detect problems resulting from different environments...
you're right. There are many reproducibility problems that are not because environments are different, but even on the same env, 2 builds give different results: if you look at the jdo issue for 3.2 release, it's not because of environment https://github.com/jvm-repo-rebuild/reproducible-central/blob/master/content/org/apache/jdo/jdo-3.2.diffoscope .
> Should the second line be `mvn clean verify artifact:compare`?
as you wish: output is expected to be done at `package` stage, `verify` is not expected to add anything. But you can and should customize the command to match your build expectations
> At what point in the release process is this best executed?
it is not expected to be executed during the release process: it's expected to be executed when you develop.
Once the release is done, people outside your project will try to rebuild (obviously with different environment) and check they can get the same output as you: if they find an issue, it's too late for the release, it will have to be fixed for the next release, so during the development phase before the next release: hence the provided test commands to run during development
Once you have a release that was reproducible, in general, next ones are also reproducible, because build structure does not change often.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jdo-dev-unsubscribe@db.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [db-jdo] mboapache merged pull request #36: upgrade Felix maven-bundle-plugin for Reproducible
Posted by GitBox <gi...@apache.org>.
mboapache merged pull request #36:
URL: https://github.com/apache/db-jdo/pull/36
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jdo-dev-unsubscribe@db.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [db-jdo] tzaeschke commented on pull request #36: upgrade Felix maven-bundle-plugin for Reproducible
Posted by GitBox <gi...@apache.org>.
tzaeschke commented on pull request #36:
URL: https://github.com/apache/db-jdo/pull/36#issuecomment-1048577614
@hboutemy I forgot: thanks for the info!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jdo-dev-unsubscribe@db.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [db-jdo] mboapache commented on pull request #36: upgrade Felix maven-bundle-plugin for Reproducible
Posted by GitBox <gi...@apache.org>.
mboapache commented on pull request #36:
URL: https://github.com/apache/db-jdo/pull/36#issuecomment-1029380418
The change looks good. Thank you!
We are planning to merge this pull request once we are done with the current JDO release 3.2.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jdo-dev-unsubscribe@db.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [db-jdo] tzaeschke commented on pull request #36: upgrade Felix maven-bundle-plugin for Reproducible
Posted by GitBox <gi...@apache.org>.
tzaeschke commented on pull request #36:
URL: https://github.com/apache/db-jdo/pull/36#issuecomment-1042985338
@hboutemy I had a look around and I do not fully understand how this works, maybe you can help or point us to some additional documentation?
* `mvn clean install` & `mvn clean package artifact:compare`: What is the purpose? As far as I understand it simply compares two local builds that were created on the same machine + environment. This will never detect problems resulting from different environments...?
* Should the second line be `mvn clean verify artifact:compare`?
* At what point in the release process is this best executed? It feels like it would need to be in the middle of `release:perform` in order to compare the final build (including version numbers) but before it is being uploaded. Still, it would only compare builds executed on the same environment....?
References:
* https://reproducible-builds.org/docs/jvm/
* https://github.com/jvm-repo-rebuild/reproducible-central/blob/master/BUILDSPEC.md
* https://maven.apache.org/guides/mini/guide-reproducible-builds.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jdo-dev-unsubscribe@db.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [db-jdo] hboutemy commented on pull request #36: upgrade Felix maven-bundle-plugin for Reproducible
Posted by GitBox <gi...@apache.org>.
hboutemy commented on pull request #36:
URL: https://github.com/apache/db-jdo/pull/36#issuecomment-1029714964
thank you
FYI, this 3.2 release (before this update) has only 1 non reproducible output: https://github.com/jvm-repo-rebuild/reproducible-central#org.apache.jdo:jdo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jdo-dev-unsubscribe@db.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [db-jdo] hboutemy edited a comment on pull request #36: upgrade Felix maven-bundle-plugin for Reproducible
Posted by GitBox <gi...@apache.org>.
hboutemy edited a comment on pull request #36:
URL: https://github.com/apache/db-jdo/pull/36#issuecomment-1029714964
thank you
FYI, this 3.2 release (before this update) has only 1 non reproducible output: https://github.com/jvm-repo-rebuild/reproducible-central#org.apache.jdo:jdo
and you can check reproducibility by simply doing
```
mvn clean install
mvn clean package artifact:compare
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jdo-dev-unsubscribe@db.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org