You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/10/21 16:02:24 UTC
[GitHub] [spark] cloud-fan commented on issue #26190: [SPARK-29532][SQL]
simplify interval string parsing
cloud-fan commented on issue #26190: [SPARK-29532][SQL] simplify interval string parsing
URL: https://github.com/apache/spark/pull/26190#issuecomment-544583979
I agree with you that performance may matter if we need to support bulk loading of interval strings. We can propose a faster version of interval parsing at that time (also benchmark). For now I don't think it's worth to keep 2 versions of interval parsing: one in antlr and one in hand-written java.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org