[GitHub] [arrow] assignUser commented on a diff in pull request #35196: GH-35179: [C++] Fix IMPORTED_LOCATION property for Arrow::bundled_dependencies

["assignUser (via GitHub)" <gi...@apache.org>]

assignUser commented on code in PR #35196:
URL: https://github.com/apache/arrow/pull/35196#discussion_r1169305885


##########
cpp/src/arrow/ArrowConfig.cmake.in:
##########
@@ -101,7 +101,7 @@ if(TARGET Arrow::arrow_static AND NOT TARGET Arrow::arrow_bundled_dependencies)
   foreach(CONFIGURATION ${arrow_static_configurations})
     string(TOUPPER "${CONFIGURATION}" CONFIGURATION)
     get_target_property(arrow_static_location Arrow::arrow_static
-                        LOCATION_${CONFIGURATION})
+                        IMPORTED_LOCATION_${CONFIGURATION})

Review Comment:
   > We can use LOCATION_<CONFIG> to get IMPORTED_LOCATION value:
   
   I tested this (output in the issue) and it's not working, but neither is my fix so... :rofl: 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org