You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "bobu-putheeckal (via GitHub)" <gi...@apache.org> on 2026/05/24 13:48:21 UTC
[PR] Fix calendar failed run colors [airflow]
bobu-putheeckal opened a new pull request, #67402:
URL: https://github.com/apache/airflow/pull/67402
Fixes #66959.
## What changed
- Render failed-only Calendar buckets with the failed/red color in Total Runs mode instead of the success/green palette.
- Render buckets containing both successful/running and failed runs as split green/red cells.
- Add focused Calendar scale tests for failed-only and mixed actual Total Runs buckets.
## Tests
- `npx --yes pnpm@10.25.0 test src/pages/Dag/Calendar/calendarUtils.test.ts`
- `npx --yes pnpm@10.25.0 exec tsc --p tsconfig.app.json --noEmit`
- `npx --yes pnpm@10.25.0 exec eslint src/pages/Dag/Calendar/calendarUtils.ts src/pages/Dag/Calendar/calendarUtils.test.ts`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix calendar failed run colors [airflow]
Posted by "choo121600 (via GitHub)" <gi...@apache.org>.
choo121600 commented on PR #67402:
URL: https://github.com/apache/airflow/pull/67402#issuecomment-4529083439
For your other UI-related PRs as well, it would be helpful if you could include before/after screenshots in the PR description.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix calendar failed run colors [airflow]
Posted by "bobu-putheeckal (via GitHub)" <gi...@apache.org>.
bobu-putheeckal commented on PR #67402:
URL: https://github.com/apache/airflow/pull/67402#issuecomment-4529800330
Added more detail here for the visual change: the affected Calendar Total Runs buckets now render failed-only days with the failed/red palette, and mixed success+failed days with split green/red cells instead of solid success green. I do not have a reliable local backend-rendered Calendar fixture for a true before/after screenshot in this environment, so I kept the verification focused on the color-selection regression tests in `calendarUtils.test.ts`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix calendar failed run colors [airflow]
Posted by "kaxil (via GitHub)" <gi...@apache.org>.
kaxil commented on PR #67402:
URL: https://github.com/apache/airflow/pull/67402#issuecomment-4529872485
PR template hasn't been followed on any of your PRs. As such I am closing all your PRs since I see little to no evidence of actual testing and mass PRs to Airflow & other repos.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix calendar failed run colors [airflow]
Posted by "kaxil (via GitHub)" <gi...@apache.org>.
kaxil closed pull request #67402: Fix calendar failed run colors
URL: https://github.com/apache/airflow/pull/67402
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org