[hudi] branch master updated: [HUDI-709] Add unit test for UtilsCommand (#1686)

[vi...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

vinoyang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/hudi.git


The following commit(s) were added to refs/heads/master by this push:
     new 5099a91  [HUDI-709] Add unit test for UtilsCommand (#1686)
5099a91 is described below

commit 5099a91edd3aaba114a86251336ae98374722270
Author: hongdd <jn...@163.com>
AuthorDate: Thu Jun 18 19:54:14 2020 +0800

    [HUDI-709] Add unit test for UtilsCommand (#1686)
---
 .../org/apache/hudi/cli/commands/UtilsCommand.java | 15 +++--
 .../apache/hudi/cli/commands/TestUtilsCommand.java | 77 ++++++++++++++++++++++
 2 files changed, 88 insertions(+), 4 deletions(-)

diff --git a/hudi-cli/src/main/java/org/apache/hudi/cli/commands/UtilsCommand.java b/hudi-cli/src/main/java/org/apache/hudi/cli/commands/UtilsCommand.java
index eebcfbb..677cb7f 100644
--- a/hudi-cli/src/main/java/org/apache/hudi/cli/commands/UtilsCommand.java
+++ b/hudi-cli/src/main/java/org/apache/hudi/cli/commands/UtilsCommand.java
@@ -18,6 +18,7 @@
 
 package org.apache.hudi.cli.commands;
 
+import org.apache.hudi.common.util.StringUtils;
 import org.springframework.shell.core.CommandMarker;
 import org.springframework.shell.core.annotation.CliCommand;
 import org.springframework.shell.core.annotation.CliOption;
@@ -30,9 +31,15 @@ import org.springframework.stereotype.Component;
 public class UtilsCommand implements CommandMarker {
 
   @CliCommand(value = "utils loadClass", help = "Load a class")
-  public String loadClass(@CliOption(key = {"class"}, help = "Check mode") final String clazz) throws Exception {
-    Class klass = Class.forName(clazz);
-    return klass.getProtectionDomain().getCodeSource().getLocation().toExternalForm();
+  public String loadClass(@CliOption(key = {"class"}, help = "Check mode") final String clazz) {
+    if (StringUtils.isNullOrEmpty(clazz)) {
+      return "Class to be loaded can not be null!";
+    }
+    try {
+      Class klass = Class.forName(clazz);
+      return klass.getProtectionDomain().getCodeSource().getLocation().toExternalForm();
+    } catch (ClassNotFoundException e) {
+      return String.format("Class %s not found!", clazz);
+    }
   }
-
 }
diff --git a/hudi-cli/src/test/java/org/apache/hudi/cli/commands/TestUtilsCommand.java b/hudi-cli/src/test/java/org/apache/hudi/cli/commands/TestUtilsCommand.java
new file mode 100644
index 0000000..63c4bcd
--- /dev/null
+++ b/hudi-cli/src/test/java/org/apache/hudi/cli/commands/TestUtilsCommand.java
@@ -0,0 +1,77 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hudi.cli.commands;
+
+import org.apache.hudi.cli.testutils.AbstractShellIntegrationTest;
+import org.apache.hudi.table.HoodieTable;
+
+import org.junit.jupiter.api.Test;
+import org.springframework.shell.core.CommandResult;
+
+import static org.junit.jupiter.api.Assertions.assertAll;
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertNotNull;
+import static org.junit.jupiter.api.Assertions.assertTrue;
+
+/**
+ * Test class for {@link org.apache.hudi.cli.commands.UtilsCommand}.
+ */
+public class TestUtilsCommand extends AbstractShellIntegrationTest {
+
+  /**
+   * Test case for success load class.
+   */
+  @Test
+  public void testLoadClass() {
+    String name = HoodieTable.class.getName();
+    CommandResult cr = getShell().executeCommand(String.format("utils loadClass --class %s", name));
+    assertAll("Command runs success",
+        () -> assertTrue(cr.isSuccess()),
+        () -> assertNotNull(cr.getResult().toString()),
+        () -> assertTrue(cr.getResult().toString().startsWith("file:")));
+  }
+
+  /**
+   * Test case for class not found.
+   */
+  @Test
+  public void testLoadClassNotFound() {
+    String name = "test.class.NotFound";
+    CommandResult cr = getShell().executeCommand(String.format("utils loadClass --class %s", name));
+
+    assertAll("Command runs success",
+        () -> assertTrue(cr.isSuccess()),
+        () -> assertNotNull(cr.getResult().toString()),
+        () -> assertEquals(cr.getResult().toString(), String.format("Class %s not found!", name)));
+  }
+
+  /**
+   * Test case for load null class.
+   */
+  @Test
+  public void testLoadClassNull() {
+    String name = "";
+    CommandResult cr = getShell().executeCommand(String.format("utils loadClass --class %s", name));
+
+    assertAll("Command runs success",
+        () -> assertTrue(cr.isSuccess()),
+        () -> assertNotNull(cr.getResult().toString()),
+        () -> assertEquals("Class to be loaded can not be null!", cr.getResult().toString()));
+  }
+}