[GitHub] pritidesai commented on a change in pull request #375: Make interative mode able to set to false

[gi...@git.apache.org]

pritidesai commented on a change in pull request #375: Make interative mode able to set to false
URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/375#discussion_r134898915
 
 

 ##########
 File path: deployers/servicedeployer.go
 ##########
 @@ -119,7 +119,7 @@ func (deployer *ServiceDeployer) ConstructDeploymentPlan() error {
 
 	manifestReader.InitRootPackage(manifestParser, manifest)
 
-	if deployer.IsDefault == true && !utils.Flags.WithinOpenWhisk {
 
 Review comment:
   @lionelvillard had added this flag to indicate that the wskdeploy is being run as an OpenWhisk action itself. If it is being run as an OpenWhisk action than skip this whole block of execution where wskdeploy is reading and inspecting project directory where action files are located, reading content of the action files and setting exec.Code of an ActionRecord. Hope this helps. We cannot set exec.Code this way if wskdeploy is running as an OpenWhisk action as none of the directory structure is accessible in cloud. But than I am trying to figure out myself what is the use of having wskdeploy run as an OpenWhisk action. 
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services