You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by GitBox <gi...@apache.org> on 2020/02/26 05:44:47 UTC
[GitHub] [storm] RuiLi8080 opened a new pull request #3216: [STORM-3589]
Prevent inconsistent results from consecutive hasNext and next calls in
LazyNodeSortingIterator
RuiLi8080 opened a new pull request #3216: [STORM-3589] Prevent inconsistent results from consecutive hasNext and next calls in LazyNodeSortingIterator
URL: https://github.com/apache/storm/pull/3216
Prevent the problem that consecutive hasNext() calls will lose elements in nodeIterator without using it.
Prevent the problem that consecutive next() calls will skip to post iterator since _nextValueFromNode_ is null even if nodeIterator still have available elements.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [storm] Ethanlm merged pull request #3216: [STORM-3589] Prevent
inconsistent results from consecutive hasNext and next calls in
LazyNodeSortingIterator
Posted by GitBox <gi...@apache.org>.
Ethanlm merged pull request #3216: [STORM-3589] Prevent inconsistent results from consecutive hasNext and next calls in LazyNodeSortingIterator
URL: https://github.com/apache/storm/pull/3216
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [storm] RuiLi8080 commented on issue #3216: [STORM-3589] Prevent
inconsistent results from consecutive hasNext and next calls in
LazyNodeSortingIterator
Posted by GitBox <gi...@apache.org>.
RuiLi8080 commented on issue #3216: [STORM-3589] Prevent inconsistent results from consecutive hasNext and next calls in LazyNodeSortingIterator
URL: https://github.com/apache/storm/pull/3216#issuecomment-591613791
@Ethanlm Wow sorry for overlook this. Thanks for pointing out. Fixed and force pushed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [storm] Ethanlm commented on issue #3216: [STORM-3589] Prevent
inconsistent results from consecutive hasNext and next calls in
LazyNodeSortingIterator
Posted by GitBox <gi...@apache.org>.
Ethanlm commented on issue #3216: [STORM-3589] Prevent inconsistent results from consecutive hasNext and next calls in LazyNodeSortingIterator
URL: https://github.com/apache/storm/pull/3216#issuecomment-591585220
Good catch. But I think there is a bug in this code:
first assume `pre` and `post` are both empty to simplify discussion.
if every node is in the `skip` list, the first call of `hasNext` will return `false` (which is correct), the second call of `hasNext` will return `true` since `nextValueFromNode` is no longer `null`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services