You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/04/30 15:50:01 UTC

[GitHub] [incubator-superset] dpgaspar opened a new pull request #9704: perf(dashboards): improve API performance for dashboards

dpgaspar opened a new pull request #9704:
URL: https://github.com/apache/incubator-superset/pull/9704


   ### CATEGORY
   
   - [ ] Bug Fix
   - [X] Enhancement (new features, refinement)
   - [ ] Refactor
   - [ ] Add tests
   - [ ] Build / Development Environment
   - [ ] Documentation
   
   ### SUMMARY
   Uses new FAB 2.3.4 that improves performance on table joins. Again like stated on #9619, when using properties has virtual columns, we should to make sure that the method references columns already referenced on `list_columns` or SQLAlchemy will issue a new query
    
   Before:
   [stats_logger] (timing) DashboardRestApi.get_list.time 110ms - 150ms
   
   After:
   [stats_logger] (timing) DashboardRestApi.get_list.time 15ms - 30ms
   
   ### ADDITIONAL INFORMATION
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   ### REVIEWERS
   @willbarrett


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org