You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/07/03 03:48:22 UTC

[GitHub] [incubator-nuttx-apps] tunefs opened a new pull request #797: netutils/ftpc: ftpc_connect: Fixed invalid socket close.

tunefs opened a new pull request #797:
URL: https://github.com/apache/incubator-nuttx-apps/pull/797


   ## Summary
   
   I fixed a problem where ftpc would close stdin (0).
   
   ftpc_connect()
     zero fill SESSION structure (cmd, data, dacceptor socket is zero)
     and connect cmd socket.
   ftpc_login()
     execute login sequence on cmd socket.
   ftpc_getfile() / ftpc_putfile()
     connect data socket (PASV).
     transfer data on data socket.
     close socket. (descriptor set to -1)
   ftpc_quit()
     close all socket.
       close cmd socket (OK).
       close data socket (-1, so it'll be EBADF, it's OK).
       close dacceptor socket (zero is stdin, stdin will be closed).
   
   By setting the socket descriptor to -1 initially, stdin will not be closed.
   
   ## Impact
   
   ## Testing
   
   I tested my local app, on Spresense.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #797: netutils/ftpc: ftpc_connect: Fixed invalid socket close.

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #797:
URL: https://github.com/apache/incubator-nuttx-apps/pull/797#issuecomment-873354099


   The build fix here: https://github.com/apache/incubator-nuttx/pull/4051


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #797: netutils/ftpc: ftpc_connect: Fixed invalid socket close.

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #797:
URL: https://github.com/apache/incubator-nuttx-apps/pull/797


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org