You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by bhavik patel <bh...@gmail.com> on 2022/04/28 09:38:54 UTC

Review Request 73963: RANGER-3737 : Usersync is broken due to NullPointerException

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73963/
-----------------------------------------------------------

Review request for ranger, Kirby Zhou, Abhay Kulkarni, Madhan Neethiraj, Mateen Mansoori, Mehul Parikh, Pradeep Agrawal, and Ramesh Mani.


Bugs: RANGER-3737
    https://issues.apache.org/jira/browse/RANGER-3737


Repository: ranger


Description
-------

Usersync is broken due to NullPointerException*. 

Detailed exception Message copied at Jira board.


Diffs
-----

  security-admin/src/main/java/org/apache/ranger/security/handler/RangerAuthenticationProvider.java 7c21c1f29 


Diff: https://reviews.apache.org/r/73963/diff/1/


Testing
-------

Verfied on cluster and usersync are working fine.


Thanks,

bhavik patel

Re: Review Request 73963: RANGER-3737 : Usersync is broken due to NullPointerException

Posted by bhavik patel <bh...@gmail.com>.

> On April 28, 2022, 10:05 a.m., Kirby Zhou wrote:
> > I have some doubts, under what circumstances will sessionMgr == null.
> > Spring shoud auto-wire it.
> > Maybe we should check whether authentication == null instead.
> 
> bhavik patel wrote:
>     exactly sessionMgr is comming as a null. I tried by removing that check.
> 
> Kirby Zhou wrote:
>     Can you show me your test case?

we can discuss at Jira board.


- bhavik


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73963/#review224382
-----------------------------------------------------------


On April 28, 2022, 10:16 a.m., bhavik patel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73963/
> -----------------------------------------------------------
> 
> (Updated April 28, 2022, 10:16 a.m.)
> 
> 
> Review request for ranger, Kirby Zhou, Abhay Kulkarni, Madhan Neethiraj, Mateen Mansoori, Mehul Parikh, Pradeep Agrawal, and Ramesh Mani.
> 
> 
> Bugs: RANGER-3737
>     https://issues.apache.org/jira/browse/RANGER-3737
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Usersync is broken due to NullPointerException*. 
> 
> Detailed exception Message copied at Jira board.
> 
> 
> Diffs
> -----
> 
>   security-admin/src/main/java/org/apache/ranger/security/handler/RangerAuthenticationProvider.java 7c21c1f29 
> 
> 
> Diff: https://reviews.apache.org/r/73963/diff/2/
> 
> 
> Testing
> -------
> 
> Verfied on cluster and usersync are working fine.
> 
> 
> Thanks,
> 
> bhavik patel
> 
>

Re: Review Request 73963: RANGER-3737 : Usersync is broken due to NullPointerException

Posted by bhavik patel <bh...@gmail.com>.

> On April 28, 2022, 10:05 a.m., Kirby Zhou wrote:
> > I have some doubts, under what circumstances will sessionMgr == null.
> > Spring shoud auto-wire it.
> > Maybe we should check whether authentication == null instead.

exactly sessionMgr is comming as a null. I tried by removing that check.


- bhavik


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73963/#review224382
-----------------------------------------------------------


On April 28, 2022, 10:16 a.m., bhavik patel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73963/
> -----------------------------------------------------------
> 
> (Updated April 28, 2022, 10:16 a.m.)
> 
> 
> Review request for ranger, Kirby Zhou, Abhay Kulkarni, Madhan Neethiraj, Mateen Mansoori, Mehul Parikh, Pradeep Agrawal, and Ramesh Mani.
> 
> 
> Bugs: RANGER-3737
>     https://issues.apache.org/jira/browse/RANGER-3737
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Usersync is broken due to NullPointerException*. 
> 
> Detailed exception Message copied at Jira board.
> 
> 
> Diffs
> -----
> 
>   security-admin/src/main/java/org/apache/ranger/security/handler/RangerAuthenticationProvider.java 7c21c1f29 
> 
> 
> Diff: https://reviews.apache.org/r/73963/diff/2/
> 
> 
> Testing
> -------
> 
> Verfied on cluster and usersync are working fine.
> 
> 
> Thanks,
> 
> bhavik patel
> 
>

Re: Review Request 73963: RANGER-3737 : Usersync is broken due to NullPointerException

Posted by bhavik patel <bh...@gmail.com>.

> On April 28, 2022, 10:05 a.m., Kirby Zhou wrote:
> > security-admin/src/main/java/org/apache/ranger/security/handler/RangerAuthenticationProvider.java
> > Line 22 (original)
> > <https://reviews.apache.org/r/73963/diff/1/?file=2267761#file2267761line22>
> >
> >     "import xxx" is not related to this bug.

my bad I mixed other changes with this patch.


- bhavik


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73963/#review224382
-----------------------------------------------------------


On April 28, 2022, 10:16 a.m., bhavik patel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73963/
> -----------------------------------------------------------
> 
> (Updated April 28, 2022, 10:16 a.m.)
> 
> 
> Review request for ranger, Kirby Zhou, Abhay Kulkarni, Madhan Neethiraj, Mateen Mansoori, Mehul Parikh, Pradeep Agrawal, and Ramesh Mani.
> 
> 
> Bugs: RANGER-3737
>     https://issues.apache.org/jira/browse/RANGER-3737
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Usersync is broken due to NullPointerException*. 
> 
> Detailed exception Message copied at Jira board.
> 
> 
> Diffs
> -----
> 
>   security-admin/src/main/java/org/apache/ranger/security/handler/RangerAuthenticationProvider.java 7c21c1f29 
> 
> 
> Diff: https://reviews.apache.org/r/73963/diff/2/
> 
> 
> Testing
> -------
> 
> Verfied on cluster and usersync are working fine.
> 
> 
> Thanks,
> 
> bhavik patel
> 
>

Re: Review Request 73963: RANGER-3737 : Usersync is broken due to NullPointerException

Posted by Kirby Zhou <ki...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73963/#review224382
-----------------------------------------------------------



I have some doubts, under what circumstances will sessionMgr == null.
Spring shoud auto-wire it.
Maybe we should check whether authentication == null instead.


security-admin/src/main/java/org/apache/ranger/security/handler/RangerAuthenticationProvider.java
Line 22 (original)
<https://reviews.apache.org/r/73963/#comment313218>

    "import xxx" is not related to this bug.


- Kirby Zhou


On 四月 28, 2022, 9:38 a.m., bhavik patel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73963/
> -----------------------------------------------------------
> 
> (Updated 四月 28, 2022, 9:38 a.m.)
> 
> 
> Review request for ranger, Kirby Zhou, Abhay Kulkarni, Madhan Neethiraj, Mateen Mansoori, Mehul Parikh, Pradeep Agrawal, and Ramesh Mani.
> 
> 
> Bugs: RANGER-3737
>     https://issues.apache.org/jira/browse/RANGER-3737
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Usersync is broken due to NullPointerException*. 
> 
> Detailed exception Message copied at Jira board.
> 
> 
> Diffs
> -----
> 
>   security-admin/src/main/java/org/apache/ranger/security/handler/RangerAuthenticationProvider.java 7c21c1f29 
> 
> 
> Diff: https://reviews.apache.org/r/73963/diff/1/
> 
> 
> Testing
> -------
> 
> Verfied on cluster and usersync are working fine.
> 
> 
> Thanks,
> 
> bhavik patel
> 
>

Re: Review Request 73963: RANGER-3737 : Usersync is broken due to NullPointerException

Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73963/#review224399
-----------------------------------------------------------


Ship it!




Ship It!

- Madhan Neethiraj


On April 28, 2022, 10:16 a.m., bhavik patel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73963/
> -----------------------------------------------------------
> 
> (Updated April 28, 2022, 10:16 a.m.)
> 
> 
> Review request for ranger, Kirby Zhou, Abhay Kulkarni, Madhan Neethiraj, Mateen Mansoori, Mehul Parikh, Pradeep Agrawal, and Ramesh Mani.
> 
> 
> Bugs: RANGER-3737
>     https://issues.apache.org/jira/browse/RANGER-3737
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Usersync is broken due to NullPointerException*. 
> 
> Detailed exception Message copied at Jira board.
> 
> 
> Diffs
> -----
> 
>   security-admin/src/main/java/org/apache/ranger/security/handler/RangerAuthenticationProvider.java 7c21c1f29 
> 
> 
> Diff: https://reviews.apache.org/r/73963/diff/2/
> 
> 
> Testing
> -------
> 
> Verfied on cluster and usersync are working fine.
> 
> 
> Thanks,
> 
> bhavik patel
> 
>

Re: Review Request 73963: RANGER-3737 : Usersync is broken due to NullPointerException

Posted by Kirby Zhou <ki...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73963/#review224407
-----------------------------------------------------------


Ship it!




Ship It!

- Kirby Zhou


On 四月 28, 2022, 10:16 a.m., bhavik patel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73963/
> -----------------------------------------------------------
> 
> (Updated 四月 28, 2022, 10:16 a.m.)
> 
> 
> Review request for ranger, Kirby Zhou, Abhay Kulkarni, Madhan Neethiraj, Mateen Mansoori, Mehul Parikh, Pradeep Agrawal, and Ramesh Mani.
> 
> 
> Bugs: RANGER-3737
>     https://issues.apache.org/jira/browse/RANGER-3737
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Usersync is broken due to NullPointerException*. 
> 
> Detailed exception Message copied at Jira board.
> 
> 
> Diffs
> -----
> 
>   security-admin/src/main/java/org/apache/ranger/security/handler/RangerAuthenticationProvider.java 7c21c1f29 
> 
> 
> Diff: https://reviews.apache.org/r/73963/diff/2/
> 
> 
> Testing
> -------
> 
> Verfied on cluster and usersync are working fine.
> 
> 
> Thanks,
> 
> bhavik patel
> 
>

Re: Review Request 73963: RANGER-3737 : Usersync is broken due to NullPointerException

Posted by bhavik patel <bh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73963/
-----------------------------------------------------------

(Updated April 28, 2022, 10:16 a.m.)


Review request for ranger, Kirby Zhou, Abhay Kulkarni, Madhan Neethiraj, Mateen Mansoori, Mehul Parikh, Pradeep Agrawal, and Ramesh Mani.


Bugs: RANGER-3737
    https://issues.apache.org/jira/browse/RANGER-3737


Repository: ranger


Description
-------

Usersync is broken due to NullPointerException*. 

Detailed exception Message copied at Jira board.


Diffs (updated)
-----

  security-admin/src/main/java/org/apache/ranger/security/handler/RangerAuthenticationProvider.java 7c21c1f29 


Diff: https://reviews.apache.org/r/73963/diff/2/

Changes: https://reviews.apache.org/r/73963/diff/1-2/


Testing
-------

Verfied on cluster and usersync are working fine.


Thanks,

bhavik patel