[GitHub] [airflow] dstandish commented on a diff in pull request #32249: Schedulers are issuing abrupt pod deletes when there is a delay in schedulers' heartbeat

["dstandish (via GitHub)" <gi...@apache.org>]

dstandish commented on code in PR #32249:
URL: https://github.com/apache/airflow/pull/32249#discussion_r1269791216


##########
airflow/executors/kubernetes_executor_utils.py:
##########
@@ -143,6 +146,13 @@ def _run(
             self.log.debug("Event: %s had an event of type %s", task.metadata.name, event["type"])
             if event["type"] == "ERROR":
                 return self.process_error(event)
+            # Schedulers are issuing abrupt pod deletes when there is a delay in schedulers' heartbeat
+            # https://github.com/apache/airflow/issues/31198
+            # Added below scheduler_job_id condition to skip the events of pods created by other schedulers

Review Comment:
   I would move these comments (here and on 132) to (1) the commit message and (2) the test.  Don't think they are needed here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org